Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Support for Deprecated SSLv3 #14412

Closed
wants to merge 1 commit into from

Conversation

alrs
Copy link
Contributor

@alrs alrs commented Nov 8, 2019

The Go authors deprecated support for SSLv3 in go 1.13. They've decided to remove it in go 1.14, and have already merged the commit.

See: https://golang.org/issue/32716

This PR, or something like it, should probably land before February 2020.

….VersionSSL30

libbeat/outputs/transport/tls.go: remove support for deprecated tls.VersionSSL30
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@jsoriano jsoriano requested a review from a team November 15, 2019 12:56
@kvch kvch requested a review from faec November 15, 2019 17:01
@urso
Copy link

urso commented Nov 18, 2019

@faec please have a look. For now lets add a deprecation warning if older versions are configured.

@mergify
Copy link
Contributor

mergify bot commented Apr 7, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b remove-deprecated-SSLv3 upstream/remove-deprecated-SSLv3
git merge upstream/master
git push upstream remove-deprecated-SSLv3

@mergify
Copy link
Contributor

mergify bot commented Sep 22, 2021

This pull request does not have a backport label. Could you fix it @alrs? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Sep 22, 2021
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 22, 2021
@jsoriano jsoriano added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Oct 25, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 25, 2021
@jlind23
Copy link
Collaborator

jlind23 commented Jan 6, 2022

@faec @rdner can we have your eyes on this?

@faec
Copy link
Contributor

faec commented Jan 28, 2022

Closing this version -- it was out of sync and missed a number of occurrences (including in the docs), but a more complete version was just checked in.

@faec faec closed this Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify libbeat review Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants