[7.3] Add ability to override cluster_uuid to be used in monitoring data (#13182) #13480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…13182) * Add ability to override cluster_uuid to be used in monitoring data * Removing changes committed by accident * Updating setting name and inline comments in reference config file * Updating setting name in code * Use struct tags pattern instead of repeating magic string * Fixing logic after variable rename * Remove unnecessary check and override * Fixing duplicate comment * Fixing comment * Updating comment
|
FYI: on review of this backport, I noticed some things that were missed in the original PR. Instead of including them here, I have opened a new PR to address the changes. It is here: #13485 I approved this one, assuming that we can just backport the fix above into 7.3 after this goes in. |
cachedout
approved these changes
Sep 4, 2019
|
@cachedout Thanks for the fixes PR but those should be covered when I merge and backport #13481. So you can close out #13485. |
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…lastic#13182) (elastic#13480) * Add ability to override cluster_uuid to be used in monitoring data * Removing changes committed by accident * Updating setting name and inline comments in reference config file * Updating setting name in code * Use struct tags pattern instead of repeating magic string * Fixing logic after variable rename * Remove unnecessary check and override * Fixing duplicate comment * Fixing comment * Updating comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.3: