Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore_device_id config flag to filebeat #13393

Closed
wants to merge 1 commit into from

Conversation

breml
Copy link
Contributor

@breml breml commented Aug 29, 2019

Additional config flag, which allows to disable the device_id as part of the
unique file identification for situations, where the device ID is not
stable.

Fixes: #13314

Additional config flag, which allows to disable the device_id as part of the
unique file identification for situations, where the device ID is not
stable.
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@breml
Copy link
Contributor Author

breml commented Aug 29, 2019

The implementation in this PR does not change the default behavior of filebeat and can be configured by the user, if necessary.

@kvch
Copy link
Contributor

kvch commented Aug 29, 2019

jenkins test this

@breml
Copy link
Contributor Author

breml commented Aug 30, 2019

The problem, that Jenkins is reporting does not make sense to me and I feel like this is not releated to my change but more like a fleaky test.

I extended the the PR in breml@6737c58 to also allow for automated migration from default to ignore_device_id mode.

@kvch
Copy link
Contributor

kvch commented Sep 4, 2019

I have opened an issue to discuss the issue, so we can cover as many use cases as possible: #13492
Do you mind sharing your thoughts in case we missed something? In the meantime, I am closing this PR, if that's ok with you.

@breml
Copy link
Contributor Author

breml commented Sep 6, 2019

@kvch I am ok with closing this PR as long as the discussions on #13492 are really progressing and are fruitful. In the past there have been similar issues as well as discussions on discuss, which have been dead ends. I will list them in #13492 for reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

filebeat flag to disable deviceId as part of the file identification in the registry
3 participants