Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sysmon Event ID 22 for ECS DNS #13323

Merged
merged 2 commits into from
Aug 27, 2019

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Aug 22, 2019

Change two fields to match ECS DNS. This is a follow-up to #13116 now that the field names are finalized.

Needs:

  • dns.question.registered_domain

Change two fields to match ECS DNS. This is a follow-up to elastic#13116 now that the field names are finalized.
@andrewkroh andrewkroh force-pushed the feature/wlb/ecs-dns-sysmon branch from e583017 to 53475a3 Compare August 26, 2019 16:22
@andrewkroh andrewkroh marked this pull request as ready for review August 26, 2019 16:23
@andrewkroh andrewkroh requested a review from a team as a code owner August 26, 2019 16:23
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem

@andrewkroh andrewkroh force-pushed the feature/wlb/ecs-dns-sysmon branch from 53475a3 to d5c8cf1 Compare August 26, 2019 16:24
Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Only failing test at this time is Metricbeat on Linux, so unrelated.

"name": "confiant-integrations.global.ssl.fastly.net"
}
"name": "confiant-integrations.global.ssl.fastly.net",
"registered_domain": "confiant-integrations.global.ssl.fastly.net"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR, but maybe we need to update the bundled public suffix list? "global.ssl.fastly.net" is in there.

@andrewkroh andrewkroh merged commit 88483a8 into elastic:master Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants