-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate building and packaging of Functionbeat by provider #12636
Separate building and packaging of Functionbeat by provider #12636
Conversation
aa42066
to
3728841
Compare
7184f8c
to
9c884ba
Compare
jenkins test this |
0769cf5
to
9c1dcb2
Compare
"time" | ||
|
||
"github.com/magefile/mage/mg" | ||
"github.com/magefile/mage/sh" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if you could utilize as many of these common targets as possible:
// mage:import
_ "github.com/elastic/beats/dev-tools/mage/target/common"
// mage:import
//_ "github.com/elastic/beats/dev-tools/mage/target/build" # You can use this one because of the custom Build() target.
// mage:import
_ "github.com/elastic/beats/dev-tools/mage/target/pkg"
// mage:import
_ "github.com/elastic/beats/dev-tools/mage/target/dashboards"
// mage:import
_ "github.com/elastic/beats/dev-tools/mage/target/test"
// mage:import
"github.com/elastic/beats/dev-tools/mage/target/unittest"
// mage:import
"github.com/elastic/beats/dev-tools/mage/target/integtest"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can I use target/build
? I am not sure I understand your comment.
Co-Authored-By: Andrew Kroh <[email protected]>
1a3096f
to
e422eea
Compare
From now on Functionbeat is separated into binaries based on cloud providers. This lead to the following naming changes:
functionbeat-{provider}
functionbeat-{provider}.yml
functionbeat-{provider}.yml
functionbeat-{provider}-{version}-{platform}.{extension}
functionbeat-{provider}-{version}-*
functionbeat-{provider}-{version}
functionbeat-{provider}-{version}
Packages are restructured to support building separately. Everything under
x-pack/functionbeat/function
is shared among all providers. On the same level,aws
andlocal
are the available provider packages.Generated files, including
fields.yml
, configurations andfields.go
, reside under the provider those belong to.Binaries, configuration, etc. can be generated from the root of Functionbeat using
mage
as before. Runningmage build|update|package|crossbuild
runs and produces outputs under the providers folder. To set which provider you want to build for passPROVIDERS
env variable a comma-separated list of providers.TODO