[Heartbeat] Use go-lookslike instead of mapval for heartbeat tests #12540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewvc
changed the title
andrewvc
added
Team:obs-ds-hosted-services
|
Pinging @elastic/uptime |
ruflin
reviewed
Jun 17, 2019
andrewvc
force-pushed
the
use-go-lookslike
branch
from
9da86ad to
8fd71aa
Compare
|
@ruflin I've addressed all your comments! |
ruflin
approved these changes
Jun 18, 2019
|
jenkins, please retest this |
|
jenkins, retest this please |
1 similar comment
|
jenkins, retest this please |
|
Jenkins, retest this please |
|
jenkins, retest this please |
1 similar comment
|
jenkins, retest this please |
|
Filebeat failure on travis is unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches our usage the built-in
mapvalpackage out in favor of the open-sourced go-lookslike package in heartbeat. There are some other places where this is used, but this is a good starting point.We can eventually delete mapval in a subsequent PR.