[Heartbeat] Fix Continuation Dispatch / mode: all pings #12458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently mode: all pings are broken. The root cause is that the scheduler dispatch of continuations in the heartbeat task model is broken. Since the only current use of this is `mode:all` pings that is what is affected. The issue was incorrectly aliasing variables when dispatching future work. This issue is well described on this wiki page https://github.com/golang/go/wiki/CommonMistakes
andrewvc
added
bug
Heartbeat
Team:obs-ds-hosted-services
|
Pinging @elastic/uptime |
ruflin
reviewed
Jun 6, 2019
|
@ruflin looks like I introduced this in 7.0.1 when I inlined this function call https://github.com/elastic/beats/pull/11895/files#diff-4d4178828d8a492b11ba6f28898cef10L122 |
andrewvc
commented
Jun 6, 2019
| @@ -162,15 +162,20 @@ func runPublishJob(job jobs.Job, client beat.Client) []scheduler.TaskFunc { | |||
| } | |||
| } | |||
|
|
|||
| if len(next) == 0 { | |||
| if !hasContinuations { | |||
There was a problem hiding this comment.
I added this here since it makes the code more readable. I know this is a bug fix, but I think some small cleanup of this function goes to that since hard to maintain code carries bug risk.
|
@ruflin added the CHANGELOG entry, also cleaned up one small thing. LMK if you think that's out of scope. |
ruflin
approved these changes
Jun 7, 2019
andrewvc
added a commit
to andrewvc/beats
that referenced
this pull request
Jun 7, 2019
Currently mode: all pings are broken. The root cause is that the scheduler dispatch of continuations in the heartbeat task model is broken. Since the only current use of this is `mode:all` pings that is what is affected. The issue was incorrectly aliasing variables when dispatching future work. This issue is well described on this wiki page https://github.com/golang/go/wiki/CommonMistakes (cherry picked from commit e491e9a)
andrewvc
removed
the
needs_backport
andrewvc
added a commit
that referenced
this pull request
Jun 7, 2019
) Currently mode: all pings are broken. The root cause is that the scheduler dispatch of continuations in the heartbeat task model is broken. Since the only current use of this is `mode:all` pings that is what is affected. The issue was incorrectly aliasing variables when dispatching future work. This issue is well described on this wiki page https://github.com/golang/go/wiki/CommonMistakes (cherry picked from commit e491e9a)
andrewvc
added a commit
to andrewvc/beats
that referenced
this pull request
Jun 12, 2019
Currently mode: all pings are broken. The root cause is that the scheduler dispatch of continuations in the heartbeat task model is broken. Since the only current use of this is `mode:all` pings that is what is affected. The issue was incorrectly aliasing variables when dispatching future work. This issue is well described on this wiki page https://github.com/golang/go/wiki/CommonMistakes
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
… (elastic#12477) Currently mode: all pings are broken. The root cause is that the scheduler dispatch of continuations in the heartbeat task model is broken. Since the only current use of this is `mode:all` pings that is what is affected. The issue was incorrectly aliasing variables when dispatching future work. This issue is well described on this wiki page https://github.com/golang/go/wiki/CommonMistakes (cherry picked from commit 4cc0a1c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently mode: all pings are broken. The root cause is that the scheduler dispatch of continuations in the heartbeat task model is broken. Since the only current use of this is
mode:allpings that is what is affected. The issue was incorrectly aliasing variables when dispatching future work.This patch also renames some of the related variables to make understanding the code here simpler.
This issue is well described on this wiki page https://github.com/golang/go/wiki/CommonMistakes