-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Auditbeat] Start system module without host ID #12373
Merged
Merged
+34
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwurm
added
review
needs_backport
PR is waiting to be backported to other branches.
Auditbeat
SecOps
labels
May 30, 2019
Pinging @elastic/secops |
andrewkroh
approved these changes
May 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cwurm
pushed a commit
to cwurm/beats
that referenced
this pull request
May 31, 2019
Allows the system module to start without the host ID. It will log a warning, and documents will not contain any `entity_id` fields. (cherry picked from commit 1328f86)
cwurm
added
v7.2.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
May 31, 2019
cwurm
pushed a commit
to cwurm/beats
that referenced
this pull request
May 31, 2019
Allows the system module to start without the host ID. It will log a warning, and documents will not contain any `entity_id` fields. (cherry picked from commit 1328f86)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…hout host ID (elastic#12374) Allows the system module to start without the host ID. It will log a warning, and documents will not contain any `entity_id` fields. (cherry picked from commit 00bb536)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, when the System module starts it runs
sysinfo.Host()
to determine the host ID to use when calculating entity IDs. This call will not always succeed on systems that do not implement all the functionality we rely on. For example, we have had reports of Synology NAS systems not having/etc/machine-id
or/etc/lsb-release
files (for getting the IDs and OS information, respectively). When this call does not succeed, Auditbeat will fail to start if the System module is enabled (which it is by default).This PR allows the module to start without the host ID. It will log a warning, and documents will not contain any
entity_id
fields.