Adding JSON paths to FB ES module docs #12008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
added
docs
Filebeat
|
Pinging @elastic/stack-monitoring |
ycombinator
added
needs_backport
dedemorton
suggested changes
May 1, 2019
Co-Authored-By: ycombinator <[email protected]>
dedemorton
approved these changes
May 1, 2019
weltenwort
approved these changes
May 2, 2019
There was a problem hiding this comment.
Thank you for this, @ycombinator. LGTM, I left just two questions below.
| @@ -70,8 +75,14 @@ Example config: | |||
| ---- | |||
| audit: | |||
| var.paths: | |||
| - /var/log/elasticsearch/*_audit.json | |||
| - /var/log/elasticsearch/*_access.log # Plain text logs | |||
| - /var/log/elasticsearch/*_audit.log # JSON logs | |||
There was a problem hiding this comment.
Is this really in JSON format a the comment suffix suggests?
There was a problem hiding this comment.
Yes, this was the case in 6.7. Starting 7.0 the JSON audit logs were put into *_audit.json. I think, to avoid confusion and complexity, I'll just remove this line altogether.
There was a problem hiding this comment.
Removed in f062d3e.
| @@ -65,8 +70,14 @@ Example config: | |||
| ---- | |||
| audit: | |||
| var.paths: | |||
| - /var/log/elasticsearch/*_audit.json | |||
| - /var/log/elasticsearch/*_access.log # Plain text logs | |||
| - /var/log/elasticsearch/*_audit.log # JSON logs | |||
There was a problem hiding this comment.
Same as above - does this file contain JSON-formatted logs?
|
I addressed your review feedback, @weltenwort. This is ready for re-review, when you get a chance. Thanks! |
weltenwort
approved these changes
May 2, 2019
cachedout
approved these changes
May 2, 2019
This was referenced May 2, 2019
ycombinator
added a commit
that referenced
this pull request
May 3, 2019
* Adding JSON paths to FB ES module docs * Adding note about ES version * Apply suggestions from code review Co-Authored-By: ycombinator <[email protected]> * Remove mention of *_audit.log to avoid confusion
ycombinator
added a commit
that referenced
this pull request
May 3, 2019
* Adding JSON paths to FB ES module docs * Adding note about ES version * Apply suggestions from code review Co-Authored-By: ycombinator <[email protected]> * Remove mention of *_audit.log to avoid confusion
ycombinator
removed
the
needs_backport
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…#12030) * Adding JSON paths to FB ES module docs * Adding note about ES version * Apply suggestions from code review Co-Authored-By: ycombinator <[email protected]> * Remove mention of *_audit.log to avoid confusion
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…#12031) * Adding JSON paths to FB ES module docs * Adding note about ES version * Apply suggestions from code review Co-Authored-By: ycombinator <[email protected]> * Remove mention of *_audit.log to avoid confusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12000.
Clarifies what log file paths to point to for the Filebeat Elasticsearch module.