[Libbeat] Fix array matching in contains condition #11691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matching arrays of strings inside a `contains` condition doesn't work
properly as it is expecting fields of type `[]string` when they are in
fact `[]interface{}`.
houndci-bot
reviewed
Apr 8, 2019
andrewkroh
reviewed
Apr 8, 2019
libbeat/conditions/matcher.go
Outdated
| @@ -86,7 +86,7 @@ func (c Matcher) Check(event ValuesMap) bool { | |||
| return false | |||
| } | |||
|
|
|||
| case []string: | |||
| case []interface{}: | |||
There was a problem hiding this comment.
What events were you seeing where it had []interface{} rather than []string? I assume this code would need to handle both data types. My guess is that []interface{} is found in data parsed by Filebeat and that []string is found in events that are natively generated in a Beat (such as a list of tags).
There was a problem hiding this comment.
You're completely right. Thanks. I got confused with maps from decoders where arrays are always of type []interface{}.
|
@andrewkroh yes, this is the issue reported in #3138 |
andrewkroh
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matching arrays of strings inside a
containscondition doesn't work properly with the output of JSON decoding as it is expecting fields of type[]stringwhen they are in this case[]interface{}.It outputs the following error:
2019-04-08T12:10:31.866+0200 WARN [conditions] conditions/matcher.go:97 unexpected type []interface {} in contains condition as it accepts only strings.Fixes: #3138