Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Kubernetes metadata fields to Filebeat CoreDNS module, and fix a documentation error - issue #11590. #11591

Merged
merged 8 commits into from
Apr 3, 2019

Conversation

alakahakai
Copy link

Address issue: Filebeat coredns module has wrong information in docs.asciidoc and some kubernetes meta fields are missing.

…cs.asciidoc. Some kubernetes meta fields are missing.
@alakahakai alakahakai self-assigned this Apr 2, 2019
@alakahakai alakahakai requested a review from a team as a code owner April 2, 2019 04:24
@alakahakai alakahakai requested a review from a team as a code owner April 2, 2019 15:20
@alakahakai alakahakai requested review from andrewkroh and removed request for andrewkroh April 2, 2019 17:42
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just an optional suggestion on the changelog messaging.

CHANGELOG.next.asciidoc Outdated Show resolved Hide resolved
@alakahakai alakahakai changed the title Address issue: Filebeat coredns module has wrong information in docs.asciidoc and some kubernetes meta fields are missing. Add missing Kubernetes metadata fields to Filebeat CoreDNS module, and fix a documentation error. Apr 2, 2019
@alakahakai alakahakai changed the title Add missing Kubernetes metadata fields to Filebeat CoreDNS module, and fix a documentation error. Add missing Kubernetes metadata fields to Filebeat CoreDNS module, and fix a documentation error. issue #11590 Apr 2, 2019
@alakahakai alakahakai changed the title Add missing Kubernetes metadata fields to Filebeat CoreDNS module, and fix a documentation error. issue #11590 Add missing Kubernetes metadata fields to Filebeat CoreDNS module, and fix a documentation error - issue #11590. Apr 2, 2019
@alakahakai alakahakai merged commit dfc7850 into elastic:master Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants