Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #11512 to 7.0: Fix field alias for nginx.access.remote_ip #11531

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

ruflin
Copy link
Contributor

@ruflin ruflin commented Mar 29, 2019

Cherry-pick of PR #11512 to 7.0 branch. Original message:

  • It was missing in the breaking changes doc (generated from ecs-migration.yml)
  • The actual field alias was incorrectly pointing to source.ip, this has been
    adjusted to source.address
  • Re-generating the documentation file also updated the breaking changes to
    include a change introduced in Adding categorization fields for the system/auth module #11334

This should be backported to 7.0.

Closes #11510

- It was missing in the breaking changes doc (generated from ecs-migration.yml)
- The actual field alias was incorrectly pointing to source.ip, this has been
  adjusted to source.address
- Re-generating the documentation file also updated the breaking changes to
  include a change introduced in elastic#11334

This should be backported to 7.0.

Closes elastic#11510

(cherry picked from commit 692ef9e)
@ruflin ruflin requested review from a team as code owners March 29, 2019 11:24
Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruflin ruflin merged commit 3c59cc8 into elastic:7.0 Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants