Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent connection error overflow on windows #11406

Closed
wants to merge 2 commits into from
Closed

Prevent connection error overflow on windows #11406

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f48df1f
Prevent connection error overflow on windows
leopucci Mar 22, 2019
1cc9682
Nil check
leopucci Mar 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion metricbeat/module/postgresql/database/database.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,15 @@ func New(base mb.BaseMetricSet) (mb.MetricSet, error) {
// of an error set the Error field of mb.Event or simply call report.Error().
func (m *MetricSet) Fetch(reporter mb.ReporterV2) {
db, err := sql.Open("postgres", m.HostData().URI)
if db != nil {
defer db.Close()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when db is nil?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a condition to check for it

}
if err != nil {
logger.Error(err)
reporter.Error(err)
return
}
defer db.Close()


results, err := postgresql.QueryStats(db, "SELECT * FROM pg_stat_database")
if err != nil {
Expand Down