Trim project from GCE cloud metadata #10987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the project info from the `cloud.machine.type` and `cloud.availability_zone` fields that are added to the add_cloud_metadata processor for Google Compute Engine (GCE). Fixes elastic#10968
tsg
reviewed
Mar 1, 2019
| @@ -31,6 +31,8 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d | |||
| - Allow Central Management to send events back to kibana. {issue}9382[9382] | |||
| - Initialize the Paths before the keystore and save the keystore into `data/{beatname}.keystore`. {pull}10706[10706] | |||
| - Add `cleanup_timeout` option to docker autodiscover, to wait some time before removing configurations after a container is stopped. {issue]10374[10374] {pull}10905[10905] | |||
| - On Google Cloud Engine (GCE) the add_cloud_metadata will now trim the project | |||
| info from the cloud.machine.type and cloud.availability_zone. {issue}10968[10968] | |||
There was a problem hiding this comment.
Should this be listed as a breaking change, to be on the safe side?
There was a problem hiding this comment.
Being safe. If you are using GCE and have queries or aggs based on the old values, they will be broken.
tsg
approved these changes
Mar 1, 2019
tsg
added
v7.0.0
needs_backport
|
@andrewkroh I think we want this backported quickly to the 7.0 branch, to make sure we don't miss the RC1. |
andrewkroh
added
v7.0.0
and removed
needs_backport
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Mar 3, 2019
This removes the project info from the cloud.machine.type and cloud.availability_zone fields that are added to the add_cloud_metadata processor for Google Compute Engine (GCE). Fixes elastic#10968, elastic#10775 (docs) (cherry picked from commit f527cd5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the project info from the
cloud.machine.typeandcloud.availability_zonefieldsthat are added to the add_cloud_metadata processor for Google Compute Engine (GCE).
Fixes #10968, #10775 (docs)