-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't expect aliases in output dictionaries #10921
Conversation
91ecca1
to
e907907
Compare
Failing tests will pass once #10927 is merged, will rebase then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code seems ok although I'm not really sure about how to test it
@sayden you can test it by writing from a module to a field documented as alias, and running the system tests for this module. For example if you revert #10927 and run I can wait to merge this if you want to give it a try. |
I don't want to block this PR. Just wanted to give you some help trying a local test. |
With the creation of aliases for ECS we have found that some features
weren't being migrated and were writing to aliases (like in #10757).
Consider writing to an alias field like writing to an undocumented field.