-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong template for postgresql statement module #10631
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Indeed, these seem to be off. I wonder why our CI did not detect this :-( To update the dependencies run |
Hi! Thank you for the update. I did not checkout the code but I user the online editor on Github. I will try than and restart the CI. |
I rebased from |
jenkins, test this |
@ruflin Sorry to bother, but it is still failing, let me know if I can help. |
@kaiyan-sheng I based the changes on this file https://github.com/elastic/beats/blob/master/metricbeat/module/postgresql/statement/data.go but also from the JSON that the module returns as shown below:
Should I also change the file you mentioned too? |
@tehmoon Thanks for pointing that out! Sorry I totally missed it. Looks like https://github.com/elastic/beats/blob/master/metricbeat/module/postgresql/statement/_meta/data.json needs to be updated. Can you also update the data.json as well please? Thank you! |
According to: https://github.com/elastic/beats/blob/master/metricbeat/module/postgresql/statement/data.go the default template casts a `long` for a `ms: float` type object
@kaiyan-sheng no worries at all! I made the change with the |
According to: https://github.com/elastic/beats/blob/master/metricbeat/module/postgresql/statement/data.go the default template casts a
long
for ams: float
type object.I don't know if there are other files to change. I suppose that's this
yaml
file that generates theelasticsearch
template. But I could be wrong.