Rename auditd fields for ECS #10577
Merged
Rename auditd fields for ECS #10577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmat
suggested changes
Feb 5, 2019
| type: keyword | ||
| type: alias | ||
| migration: true | ||
| path: error.message |
There was a problem hiding this comment.
Not a fan of using error.message for debugging output. It's not an actual error message from the source, nor is it a processing error, really, according to the description below.
There was a problem hiding this comment.
It's a processing error. For example, message would be included if an expected field were missing while processing the events from the kernel. It holds any of the error messages that are returned by go-libaudit while processing the messages.
There was a problem hiding this comment.
Gotcha, I'm good with that, then.
| @@ -25,7 +25,7 @@ | |||
| description: > | |||
| Program to run at login. | |||
| - name: user_information | |||
| type: text | |||
| type: keyword | |||
ruflin
approved these changes
Feb 5, 2019
Change `auditd.messages` to `event.original` and `auditd.warnings` to `error.message`. And also change `user.user_information` from text to keyword.
andrewkroh
force-pushed
the
feature/ab/ecs-change-event-original
branch
from
84404be to
c5fb6fa
Compare
webmat
approved these changes
Feb 5, 2019
|
Will fix. I did a rebase and lost the fix. |
|
Only Jenkins failure is metricbeat. Unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
auditd.messagestoevent.originalandauditd.warningstoerror.message.And also change
user.user_informationfrom text to keyword.