Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auditbeat] Cherry-pick #9963 to 6.x: Add user information to processes #10395

Merged
merged 4 commits into from
Jan 31, 2019

Conversation

cwurm
Copy link
Contributor

@cwurm cwurm commented Jan 29, 2019

Cherry-pick of PR #9963 to 6.x branch. Original message:

Since go-sysinfo can now report the UIDs and GIDs of a process, this adds this information to the process metricset.

The added fields are:

  • user.id (UID or SID)
  • user.name
  • user.group.id (GID or SID of primary group)
  • user.group.name
  • user.effective.id (EUID)
  • user.effective.group.id (EGID)
  • user.saved.id (SUID)
  • user.saved.group.id (SGID)

Also adds some unit tests and tightens the system test.

Christoph Wurm added 2 commits January 29, 2019 12:44
Adds real, effective, and saved UID and GID information to the process dataset.

(cherry picked from commit fa40a54)
@cwurm cwurm changed the title Cherry-pick #9963 to 6.x: [Auditbeat] Add user information to processes [Auditbeat] Cherry-pick #9963 to 6.x: Add user information to processes Jan 29, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/secops

@cwurm cwurm requested a review from a team January 29, 2019 12:51
@cwurm
Copy link
Contributor Author

cwurm commented Jan 29, 2019

I've had to add user.group.id and user.group.name explicitly since 6.x does not have full ECS. user.id and user.name were already similarly added in fields.common.yml.

@cwurm
Copy link
Contributor Author

cwurm commented Jan 30, 2019

jenkins, test this

Copy link
Contributor

@adriansr adriansr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@adriansr adriansr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwurm
Copy link
Contributor Author

cwurm commented Jan 31, 2019

jenkins, test this

@cwurm cwurm merged commit 7f27b94 into elastic:6.x Jan 31, 2019
@cwurm cwurm deleted the backport_9963_6.x branch January 31, 2019 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants