Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metricbeat dashboard for MSSQL transaction log metricset #10310

Merged

Conversation

sayden
Copy link
Contributor

@sayden sayden commented Jan 24, 2019

image

Just one thing is "missing". I think there's a bug in the PR of the transaction log because the backup time. It is recognized as string inside the index pattern while in the fields.yml file is a date https://github.com/elastic/beats/blob/master/x-pack/metricbeat/module/mssql/transaction_log/_meta/fields.yml#L45.

image

The value is correct, it's just that not backup have been done yet so the database returns its "zero value" but I think it will be nice that it has some formatting or something similar.

By the way, regarding the question about the _@ timestamp per 30 seconds` I did here #10076 (comment) the answer was the visual builder. If you build the dashboard with the visual builder, it appears as per 10 seconds

@sayden sayden added Metricbeat Metricbeat :Dashboards Team:Integrations Label for the Integrations team labels Jan 24, 2019
@sayden sayden self-assigned this Jan 24, 2019
@sayden sayden requested a review from a team as a code owner January 24, 2019 09:46
@ruflin ruflin requested a review from jsoriano January 24, 2019 12:28
@ruflin ruflin added the review label Jan 25, 2019
@sayden
Copy link
Contributor Author

sayden commented Jan 30, 2019

@jsoriano Friendly reminder here 🙂

@jsoriano
Copy link
Member

@jsoriano Friendly reminder here 🙂

Oh sorry 🙁

It LGTM as is, only a couple of things in case you want to try.

If there are more useful things below, maybe it worths to make smaller graphs and put 3 on each row, so more info is shown in a view.

I see that 5 entries are shown in each graph, is it because there are only 5 entries or because it is showing only the top N in something?
It can be good to think ahead on how the dashboard will look like if there are lots of entries, you can for example decide if showing only the top N entries and/or order them by value, and you can also consider to add an option list controller to chose the elements to show.

@sayden
Copy link
Contributor Author

sayden commented Jan 31, 2019

No worries 😄

I see that 5 entries are shown in each graph, is it because there are only 5 entries or because it is showing only the top N in something?

Very good point because, in fact, they are 5 by pure coincidence. I had 5 databases in the MSSQL instance but you can find many (I have even worked with one which had 450!). So the problem I see here is that a TopN doesn't necessarly solve the problem, as a user might want to look at the health of any database which is not in one of those 5.

Ideas, thoughts? I'm not super experienced with Kibana nor with Visual Builder but maybe it has something to deal with this scenario

If there are more useful things below, maybe it worths to make smaller graphs and put 3 on each row, so more info is shown in a view.

When I did it like this it looked a bit narrow in my opinion because legend must be visible and it takes a lot of space. I checked placing legend in the botton but then you had 3 and 3 half small and narrow graphs on the screen, which is even worse than having 4 big graphs so I prefer to leave them like this in this case.

@jsoriano
Copy link
Member

No worries smile

I see that 5 entries are shown in each graph, is it because there are only 5 entries or because it is showing only the top N in something?

Very good point because, in fact, they are 5 by pure coincidence. I had 5 databases in the MSSQL instance but you can find many (I have even worked with one which had 450!). So the problem I see here is that a TopN doesn't necessarly solve the problem, as a user might want to look at the health of any database which is not in one of those 5.

Ideas, thoughts? I'm not super experienced with Kibana nor with Visual Builder but maybe it has something to deal with this scenario

For that was my last suggestion 🙂 you can also consider to add an option list controller to chose the elements to show.

If there are more useful things below, maybe it worths to make smaller graphs and put 3 on each row, so more info is shown in a view.

When I did it like this it looked a bit narrow in my opinion because legend must be visible and it takes a lot of space. I checked placing legend in the botton but then you had 3 and 3 half small and narrow graphs on the screen, which is even worse than having 4 big graphs so I prefer to leave them like this in this case.

👍

@sayden
Copy link
Contributor Author

sayden commented Feb 1, 2019

New version with the option list controller:

image

@sayden sayden force-pushed the feature/xp/mb/dashboard-for-transaction-log branch from d1fc4e0 to 2f14abc Compare February 1, 2019 12:43
@sayden
Copy link
Contributor Author

sayden commented Feb 5, 2019

@jsoriano friendly reminder here. All good? 🙂

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great, I'd remove the buttons, but as you wish 🙂

@sayden
Copy link
Contributor Author

sayden commented Feb 5, 2019

Thanks @jsoriano We'll do a follow up PR

Error seems unrelated. Merging.

@sayden sayden merged commit 222445b into elastic:master Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Dashboards Metricbeat Metricbeat review Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants