-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metricbeat dashboard for MSSQL transaction log metricset #10310
Metricbeat dashboard for MSSQL transaction log metricset #10310
Conversation
@jsoriano Friendly reminder here 🙂 |
Oh sorry 🙁 It LGTM as is, only a couple of things in case you want to try. If there are more useful things below, maybe it worths to make smaller graphs and put 3 on each row, so more info is shown in a view. I see that 5 entries are shown in each graph, is it because there are only 5 entries or because it is showing only the top N in something? |
No worries 😄
Very good point because, in fact, they are 5 by pure coincidence. I had 5 databases in the MSSQL instance but you can find many (I have even worked with one which had 450!). So the problem I see here is that a TopN doesn't necessarly solve the problem, as a user might want to look at the health of any database which is not in one of those 5. Ideas, thoughts? I'm not super experienced with Kibana nor with Visual Builder but maybe it has something to deal with this scenario
When I did it like this it looked a bit narrow in my opinion because legend must be visible and it takes a lot of space. I checked placing legend in the botton but then you had 3 and 3 half small and narrow graphs on the screen, which is even worse than having 4 big graphs so I prefer to leave them like this in this case. |
For that was my last suggestion 🙂 you can also consider to add an option list controller to chose the elements to show.
👍 |
d1fc4e0
to
2f14abc
Compare
@jsoriano friendly reminder here. All good? 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great, I'd remove the buttons, but as you wish 🙂
Thanks @jsoriano We'll do a follow up PR Error seems unrelated. Merging. |
Just one thing is "missing". I think there's a bug in the PR of the transaction log because the backup time. It is recognized as
string
inside the index pattern while in thefields.yml
file is adate
https://github.com/elastic/beats/blob/master/x-pack/metricbeat/module/mssql/transaction_log/_meta/fields.yml#L45.The value is correct, it's just that not backup have been done yet so the database returns its "zero value" but I think it will be nice that it has some formatting or something similar.
By the way, regarding the question about the _@ timestamp per 30 seconds` I did here #10076 (comment) the answer was the visual builder. If you build the dashboard with the visual builder, it appears as per 10 seconds