Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Heartbeat] Fix NPE in HTTP responses. #10082

Merged
merged 1 commit into from
Jan 15, 2019
Merged

Conversation

andrewvc
Copy link
Contributor

This removes an accidentally duplicated line that broke the error check on the following line.

I suspect this was caused by git merging incorrectly.

Fixes #10066

This removes an accidentally duplicated line that broke the error check on the following line.

I suspect this was caused by git merging incorrectly.

Fixes elastic#10066
@andrewvc andrewvc added bug needs_backport PR is waiting to be backported to other branches. Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team labels Jan 15, 2019
@andrewvc andrewvc self-assigned this Jan 15, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime

@andrewvc andrewvc requested a review from ruflin January 15, 2019 15:10
@andrewvc andrewvc requested a review from a team as a code owner January 15, 2019 15:10
@andrewvc
Copy link
Contributor Author

This was introduced here: 4f2f917#diff-b2e3be1f1a596d8d64abc830617b8051

@andrewvc
Copy link
Contributor Author

/CC @liza-mae

@andrewvc andrewvc added v6.6.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jan 15, 2019
@ruflin
Copy link
Contributor

ruflin commented Jan 15, 2019

Would have been nice to have a test case for this, perhap system test.

@andrewvc
Copy link
Contributor Author

Failures unrelated

@andrewvc andrewvc merged commit f10ad90 into elastic:master Jan 15, 2019
@liza-mae
Copy link

Thanks @andrewvc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v6.6.0 v6.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants