Add more metrics to Performance Metricset on MSSQL Module #10011
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we add more metrics to Performance Metricset on MSSQL Module. The ones added could be considered the last ones that will be added for the sake of completeness in this Metricset.
Fields added:
logouts
: Total number of logout operations started per second.logins
: Total number of logins started per second. This does not include pooled connections.transactions
: Total number of transactions in the instance. There's another metric that returns this value per database but it's omitted. We'll place it in a different Metricset.active_temp_tables
: Number of temporary tables/table variables in use.connections_reset
: Total number of logins started from the connection pool.buffer.checkpoint_pages
: Indicates the number of pages flushed to disk per second by a checkpoint or other operation that require all dirty pages to be flushed.buffer.database_pages
: Indicates the number of pages in the buffer pool with database content.buffer.target_pages
: Ideal number of pages in the buffer pool.Fields modified. I found that few metrics were prefixed with
buffer
or has some relation with it (a total of 5) so I place them in the same object:page_life_expectancy
tobuffer.page_life_expectancy
buffer_cache_hit
tobuffer.cache_hit
More things included in this PR:
data.json
generated filefields.yml
modified and updated with the new structure of modified fields as well as new fields.