Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure union merge for Changelog*.next.asciidoc #10003

Merged
merged 2 commits into from
Jan 11, 2019

Conversation

urso
Copy link

@urso urso commented Jan 10, 2019

This change automatically merges Changelog*.next.asciidoc files when
merging or rebasing via merge=union. No more need to fix changelog
files when doing git rebase master.

Note: github UI seems to ignore the setting. Convenience will only be improved on command line.

This change automatically merges Changelog*.next.asciidoc files when
merging or rebasing via `merge=union`. No more need to fix changelog
files when doing `git rebase master`.
@ruflin
Copy link
Contributor

ruflin commented Jan 10, 2019

This is the entry that always creates the "interesting" rebases in the changelog. So I wonder if we rather leave it out instead of giving devs the impressions a clean rebase happened.

@ruflin
Copy link
Contributor

ruflin commented Jan 10, 2019

@urso I assume the label should be needs_backport not backport

@urso urso added needs_backport PR is waiting to be backported to other branches. and removed backport labels Jan 11, 2019
@urso
Copy link
Author

urso commented Jan 11, 2019

This is the entry that always creates the "interesting" rebases in the changelog

True. But with the move to Changelog.next.asciidoc the wrongly rebase is local to the current release only. We still checks for missing entries and wrong entries if really required. So far this is hasn't been an issue if entries did stay in the correct release after rebase.

Even without union merge the line can move to an unexpected location. As developer you will look for <<<<< and then just remove <<<<<<, ===========, and >>>>>>>>, such that both entries appear in the merged changelog. Rarely does one check the if the conflict is really at the right location.

I'm more tempted to remove union-merge from the Changelog.asciidoc file itself.

@ph
Copy link
Contributor

ph commented Jan 11, 2019

I'm more tempted to remove union-merge from the Changelog.asciidoc file itself.

I would be OK with that, I've made a few mistakes in changelog entries, now to be honest I always diff the change locally before creating the backports.

@urso
Copy link
Author

urso commented Jan 11, 2019

@ph @kvch I removed union merge from Changelog.asciidoc, so to force devs to have a look when Changelog.asciidoc gets merged. Please have another look.

@urso urso merged commit 05d7f5e into elastic:master Jan 11, 2019
@urso urso deleted the union-merge-next-changelog branch January 11, 2019 19:52
urso pushed a commit to urso/beats that referenced this pull request Jan 11, 2019
* configure union merge for Changelog*.next.asciidoc

This change automatically merges Changelog*.next.asciidoc files when
merging or rebasing via `merge=union`. No more need to fix changelog
files when doing `git rebase master`.

* Remove union merge from Changelog.asciidoc

(cherry picked from commit 05d7f5e)
@urso urso added v6.7.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jan 11, 2019
urso pushed a commit to urso/beats that referenced this pull request Jan 11, 2019
* configure union merge for Changelog*.next.asciidoc

This change automatically merges Changelog*.next.asciidoc files when
merging or rebasing via `merge=union`. No more need to fix changelog
files when doing `git rebase master`.

* Remove union merge from Changelog.asciidoc

(cherry picked from commit 05d7f5e)
@urso urso added the v6.6.0 label Jan 11, 2019
urso pushed a commit to urso/beats that referenced this pull request Jan 11, 2019
* configure union merge for Changelog*.next.asciidoc

This change automatically merges Changelog*.next.asciidoc files when
merging or rebasing via `merge=union`. No more need to fix changelog
files when doing `git rebase master`.

* Remove union merge from Changelog.asciidoc

(cherry picked from commit 05d7f5e)
@urso urso added the v6.5.5 label Jan 11, 2019
urso pushed a commit that referenced this pull request Jan 16, 2019
* configure union merge for Changelog*.next.asciidoc

This change automatically merges Changelog*.next.asciidoc files when
merging or rebasing via `merge=union`. No more need to fix changelog
files when doing `git rebase master`.

* Remove union merge from Changelog.asciidoc

(cherry picked from commit 05d7f5e)
urso pushed a commit that referenced this pull request Jan 23, 2019
* configure union merge for Changelog*.next.asciidoc

This change automatically merges Changelog*.next.asciidoc files when
merging or rebasing via `merge=union`. No more need to fix changelog
files when doing `git rebase master`.

* Remove union merge from Changelog.asciidoc

(cherry picked from commit 05d7f5e)
urso pushed a commit that referenced this pull request Jan 23, 2019
…asciidoc (#10026)

Cherry-pick of PR #10003 to 6.5 branch. Original message: 

This change automatically merges Changelog*.next.asciidoc files when
merging or rebasing via `merge=union`. No more need to fix changelog
files when doing `git rebase master`.

Note: github UI seems to ignore the setting. Convenience will only be improved on command line.
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…lastic#10024)

* configure union merge for Changelog*.next.asciidoc

This change automatically merges Changelog*.next.asciidoc files when
merging or rebasing via `merge=union`. No more need to fix changelog
files when doing `git rebase master`.

* Remove union merge from Changelog.asciidoc

(cherry picked from commit 64453fd)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…*.next.asciidoc (elastic#10026)

Cherry-pick of PR elastic#10003 to 6.5 branch. Original message: 

This change automatically merges Changelog*.next.asciidoc files when
merging or rebasing via `merge=union`. No more need to fix changelog
files when doing `git rebase master`.

Note: github UI seems to ignore the setting. Convenience will only be improved on command line.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants