-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configure union merge for Changelog*.next.asciidoc #10003
Conversation
This change automatically merges Changelog*.next.asciidoc files when merging or rebasing via `merge=union`. No more need to fix changelog files when doing `git rebase master`.
This is the entry that always creates the "interesting" rebases in the changelog. So I wonder if we rather leave it out instead of giving devs the impressions a clean rebase happened. |
@urso I assume the label should be |
True. But with the move to Changelog.next.asciidoc the wrongly rebase is local to the current release only. We still checks for missing entries and wrong entries if really required. So far this is hasn't been an issue if entries did stay in the correct release after rebase. Even without union merge the line can move to an unexpected location. As developer you will look for I'm more tempted to remove union-merge from the Changelog.asciidoc file itself. |
I would be OK with that, I've made a few mistakes in changelog entries, now to be honest I always diff the change locally before creating the backports. |
* configure union merge for Changelog*.next.asciidoc This change automatically merges Changelog*.next.asciidoc files when merging or rebasing via `merge=union`. No more need to fix changelog files when doing `git rebase master`. * Remove union merge from Changelog.asciidoc (cherry picked from commit 05d7f5e)
* configure union merge for Changelog*.next.asciidoc This change automatically merges Changelog*.next.asciidoc files when merging or rebasing via `merge=union`. No more need to fix changelog files when doing `git rebase master`. * Remove union merge from Changelog.asciidoc (cherry picked from commit 05d7f5e)
* configure union merge for Changelog*.next.asciidoc This change automatically merges Changelog*.next.asciidoc files when merging or rebasing via `merge=union`. No more need to fix changelog files when doing `git rebase master`. * Remove union merge from Changelog.asciidoc (cherry picked from commit 05d7f5e)
* configure union merge for Changelog*.next.asciidoc This change automatically merges Changelog*.next.asciidoc files when merging or rebasing via `merge=union`. No more need to fix changelog files when doing `git rebase master`. * Remove union merge from Changelog.asciidoc (cherry picked from commit 05d7f5e)
* configure union merge for Changelog*.next.asciidoc This change automatically merges Changelog*.next.asciidoc files when merging or rebasing via `merge=union`. No more need to fix changelog files when doing `git rebase master`. * Remove union merge from Changelog.asciidoc (cherry picked from commit 05d7f5e)
…asciidoc (#10026) Cherry-pick of PR #10003 to 6.5 branch. Original message: This change automatically merges Changelog*.next.asciidoc files when merging or rebasing via `merge=union`. No more need to fix changelog files when doing `git rebase master`. Note: github UI seems to ignore the setting. Convenience will only be improved on command line.
…lastic#10024) * configure union merge for Changelog*.next.asciidoc This change automatically merges Changelog*.next.asciidoc files when merging or rebasing via `merge=union`. No more need to fix changelog files when doing `git rebase master`. * Remove union merge from Changelog.asciidoc (cherry picked from commit 64453fd)
…*.next.asciidoc (elastic#10026) Cherry-pick of PR elastic#10003 to 6.5 branch. Original message: This change automatically merges Changelog*.next.asciidoc files when merging or rebasing via `merge=union`. No more need to fix changelog files when doing `git rebase master`. Note: github UI seems to ignore the setting. Convenience will only be improved on command line.
This change automatically merges Changelog*.next.asciidoc files when
merging or rebasing via
merge=union
. No more need to fix changelogfiles when doing
git rebase master
.Note: github UI seems to ignore the setting. Convenience will only be improved on command line.