Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Heartbeat] Set TZ=UTC for synthetics executions if none set. #36117

Closed
andrewvc opened this issue Jul 19, 2023 · 3 comments · Fixed by elastic/elastic-agent#3160
Closed

[Heartbeat] Set TZ=UTC for synthetics executions if none set. #36117

andrewvc opened this issue Jul 19, 2023 · 3 comments · Fixed by elastic/elastic-agent#3160
Labels
enhancement Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team

Comments

@andrewvc
Copy link
Contributor

It currently is possible for synthetic monitors to have no timezone set which can result in weird behavior from sites that expect one to always exists as it does on user machines. To fix this we would set TZ=UTC on docker containers where no system TZ is specified. The current behavior is very close to this, the only exception being that the browser will no send a TZ in the headers over to sites it visits.

@andrewvc andrewvc added enhancement Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team labels Jul 19, 2023
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@shahzad31
Copy link
Contributor

Workaround for this right now is set timezone explictely in playwright options

image

@emilioalvap emilioalvap self-assigned this Aug 1, 2023
emilioalvap added a commit to elastic/elastic-agent that referenced this issue Aug 4, 2023
## What does this PR do?

Fixes elastic/beats#36117 on the agent. Add
default TZ value to fix synthetic journeys for timezone-triggered
errors.

## Why is it important?

Unspecified timezone values can cause navigation errors on synthetics
journeys.

## How to test this PR locally

1. Build agent docker image locally.
2. Create a journey that navigates to a Kibana URL and enroll agent on
the private location policy.
3. Wait for Kibana login page to load properly.
mergify bot pushed a commit that referenced this issue Aug 4, 2023
## What does this PR do?

Fixes #36117. Add default TZ
value to fix synthetic journeys for timezone-triggered errors.

## Why is it important?

Unspecified timezone values can cause navigation errors on synthetics
journeys.

3# How to test this PR locally

1. Build heartbeat docker image locally.
2. Create a journey that navigates to a Kibana URL.
3. Wait for Kibana login page to load properly.

(cherry picked from commit c09b949)
mergify bot pushed a commit to elastic/elastic-agent that referenced this issue Aug 4, 2023
## What does this PR do?

Fixes elastic/beats#36117 on the agent. Add
default TZ value to fix synthetic journeys for timezone-triggered
errors.

## Why is it important?

Unspecified timezone values can cause navigation errors on synthetics
journeys.

## How to test this PR locally

1. Build agent docker image locally.
2. Create a journey that navigates to a Kibana URL and enroll agent on
the private location policy.
3. Wait for Kibana login page to load properly.

(cherry picked from commit d3a4ab7)
@emilioalvap emilioalvap removed their assignment Aug 8, 2023
@awahab07 awahab07 assigned awahab07 and unassigned awahab07 Aug 31, 2023
@awahab07
Copy link

awahab07 commented Sep 1, 2023

Post FF Testing

Tested docker.elastic.co/beats/heartbeat:8.10.0-SNAPSHOT and it LGTM.

Before After
Screenshot 2023-08-31 at 18 59 58 Screenshot 2023-09-01 at 19 18 26

Scholar-Li pushed a commit to Scholar-Li/beats that referenced this issue Feb 5, 2024
## What does this PR do?

Fixes elastic#36117. Add default TZ
value to fix synthetic journeys for timezone-triggered errors.

## Why is it important?

Unspecified timezone values can cause navigation errors on synthetics
journeys.

3# How to test this PR locally

1. Build heartbeat docker image locally.
2. Create a journey that navigates to a Kibana URL.
3. Wait for Kibana login page to load properly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants