Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Alllow filtering out some filesystem types #3459

Closed
guenhter opened this issue Jan 25, 2017 · 2 comments
Closed

Feature: Alllow filtering out some filesystem types #3459

guenhter opened this issue Jan 25, 2017 · 2 comments
Labels
enhancement help wanted Indicates that a maintainer wants help on an issue or pull request Metricbeat Metricbeat

Comments

@guenhter
Copy link

Feature Request

Original Thread:
https://discuss.elastic.co/t/disk-space-metrics-wrong-when-working-with-overlay-mounts/72442

There is currently a problem when using overlay mounts. In such case, the mount point has the same disk size as the original disk. In Kibana, these sizes are summed what is not the reality.

It should be possible, to allow filtering out all such types to only transmit the real size of the disk.
@monicasarbu monicasarbu added the help wanted Indicates that a maintainer wants help on an issue or pull request label Feb 16, 2017
@cv cv mentioned this issue Jul 20, 2017
Merged
@cv
Copy link
Contributor

cv commented Jul 20, 2017 •
edited
Loading

sigar.FileSystem.SysTypeName isn't being indexed, which makes it nearly impossible to filter out overlay filesystems. I added that field (in the PR above) so you could tell your query to drop whatever filesystem types you're not interested in.

Does that work well enough for you?

@guenhter
Copy link
Author

That's great!

cv added a commit to cv/beats that referenced this issue Jul 31, 2017
@cv
Adds a "type" field to the filesystem beat (elastic#4717)
3344656 
Its value is copied from sigar.FileSystem.SysTypeName (on Windows, sigar.FileSystem.TypeName) and passed through so that it becomes possible to filter out `overlay`, `tmpfs` or otherwise uninteresting filesystems.

Fixes elastic#3459.
andrewkroh pushed a commit that referenced this issue Aug 2, 2017
@cv @andrewkroh
Adds a "type" field to the filesystem beat (#4717) (#4717)
94a197b 
Its value is copied from sigar.FileSystem.SysTypeName (on Windows, sigar.FileSystem.TypeName) and passed through so that it becomes possible to filter out `overlay`, `tmpfs` or otherwise uninteresting filesystems.

Fixes #3459.
@tsg tsg mentioned this issue Aug 24, 2017
Merged
tsg pushed a commit to tsg/beats that referenced this issue Aug 24, 2017
@cv
Adds a "type" field to the filesystem beat (elastic#4717) (elastic#4717)
4ca2045 
Its value is copied from sigar.FileSystem.SysTypeName (on Windows, sigar.FileSystem.TypeName) and passed through so that it becomes possible to filter out `overlay`, `tmpfs` or otherwise uninteresting filesystems.

Fixes elastic#3459.

(cherry picked from commit 94a197b)
andrewkroh pushed a commit that referenced this issue Aug 24, 2017
@tsg @andrewkroh
Cherry-pick #4717 to 6.0: Adds a "type" field to the filesystem beat (#…
1018fa9 
…4991)

* Adds a "type" field to the filesystem beat (#4717) (#4717)

Its value is copied from sigar.FileSystem.SysTypeName (on Windows, sigar.FileSystem.TypeName) and passed through so that it becomes possible to filter out `overlay`, `tmpfs` or otherwise uninteresting filesystems.

Fixes #3459.

(cherry picked from commit 94a197b)
leweafan pushed a commit to leweafan/beats that referenced this issue Apr 28, 2023
@tsg @andrewkroh
Cherry-pick elastic#4717 to 6.0: Adds a "type" field to the filesyste…
843f873 
…m beat (elastic#4991)

* Adds a "type" field to the filesystem beat (elastic#4717) (elastic#4717)

Its value is copied from sigar.FileSystem.SysTypeName (on Windows, sigar.FileSystem.TypeName) and passed through so that it becomes possible to filter out `overlay`, `tmpfs` or otherwise uninteresting filesystems.

Fixes elastic#3459.

(cherry picked from commit 7e2396a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted Indicates that a maintainer wants help on an issue or pull request Metricbeat Metricbeat
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cv @ruflin @monicasarbu @guenhter