Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Heartbeat] Add no_chromium_sandbox option for synthetics #22901

Closed
andrewvc opened this issue Dec 3, 2020 · 2 comments · Fixed by #24172
Closed

[Heartbeat] Add no_chromium_sandbox option for synthetics #22901

andrewvc opened this issue Dec 3, 2020 · 2 comments · Fixed by #24172
Assignees
@justinkambic
Labels
Team:obs-ds-hosted-services Label for the Observability Hosted Services team test-plan-ok This PR passed manual testing v7.13.0

Comments

@andrewvc
Copy link
Contributor

andrewvc commented Dec 3, 2020

Describe the enhancement:

Once elastic/synthetics#136 is added to synthetics we the corresponding no sandbox option in the heartbeat yaml.

Describe a specific use case for the enhancement or feature:

This makes it easier to run chromium in docker since you don't need elevated seccomp privs
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 3, 2020
@andresrc andresrc added the Team:obs-ds-hosted-services Label for the Observability Hosted Services team label Dec 4, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 4, 2020
This was referenced Dec 4, 2020
Closed
Closed
@paulb-elastic paulb-elastic mentioned this issue Feb 23, 2021
Merged
4 tasks
@andrewvc andrewvc mentioned this issue Feb 23, 2021
Closed
andrewvc added a commit that referenced this issue Mar 4, 2021
@andrewvc
[Heartbeat] Add sandbox options, defaulted to off (#24172)
270a676 
Fixes #22901

Adds support for the sandbox options in synthetics. I haven't added tests here because we really need E2E tests for this, but those live elsewhere. Given that we're still in experimental, I think it's OK to merge this feature as-is, and circle back to it later if you're OK with it @blakerouse , I can make a placeholder issue.
@andrewvc andrewvc mentioned this issue Mar 4, 2021
Merged
4 tasks
andrewvc added a commit to andrewvc/beats that referenced this issue Mar 4, 2021
@andrewvc
[Heartbeat] Add sandbox options, defaulted to off (elastic#24172)
bd98cd0 
Fixes elastic#22901

Adds support for the sandbox options in synthetics. I haven't added tests here because we really need E2E tests for this, but those live elsewhere. Given that we're still in experimental, I think it's OK to merge this feature as-is, and circle back to it later if you're OK with it @blakerouse , I can make a placeholder issue.

(cherry picked from commit 270a676)
andrewvc added a commit that referenced this issue Mar 4, 2021
@andrewvc
[Heartbeat] Add sandbox options, defaulted to off (#24172) (#24358)
1716693 
Fixes #22901

Adds support for the sandbox options in synthetics. I haven't added tests here because we really need E2E tests for this, but those live elsewhere. Given that we're still in experimental, I think it's OK to merge this feature as-is, and circle back to it later if you're OK with it @blakerouse , I can make a placeholder issue.

(cherry picked from commit 270a676)
andrewvc added a commit to andrewvc/beats that referenced this issue Mar 4, 2021
@andrewvc
[Heartbeat] Add sandbox options, defaulted to off (elastic#24172)
c758cfc 
Fixes elastic#22901

Adds support for the sandbox options in synthetics. I haven't added tests here because we really need E2E tests for this, but those live elsewhere. Given that we're still in experimental, I think it's OK to merge this feature as-is, and circle back to it later if you're OK with it @blakerouse , I can make a placeholder issue.
@justinkambic justinkambic self-assigned this May 4, 2021
@justinkambic
Copy link
Contributor

When running a browser monitor with sandbox: true, the command that Heartbeat sends to Elastic Synthetics includes --sandbox, so I am assuming this feature is working as designed. The flag is not present when I remove the config option.

image

@justinkambic justinkambic added the test-plan-ok This PR passed manual testing label May 4, 2021
leweafan pushed a commit to leweafan/beats that referenced this issue Apr 28, 2023
@andrewvc
[Heartbeat] Add sandbox options, defaulted to off (elastic#24172)
1dcdc14 
Fixes elastic#22901

Adds support for the sandbox options in synthetics. I haven't added tests here because we really need E2E tests for this, but those live elsewhere. Given that we're still in experimental, I think it's OK to merge this feature as-is, and circle back to it later if you're OK with it @blakerouse , I can make a placeholder issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinkambic justinkambic

Labels
Team:obs-ds-hosted-services Label for the Observability Hosted Services team test-plan-ok This PR passed manual testing v7.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Heartbeat] Add sandbox options, defaulted to off andrewvc/beats
5 participants
@andrewvc @andresrc @elasticmachine @justinkambic @paulb-elastic