Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Filebeat] azure module can build storage containers with invalid names #20369

Closed
leehinman opened this issue Jul 30, 2020 · 1 comment · Fixed by #20389
Closed

[Filebeat] azure module can build storage containers with invalid names #20369

leehinman opened this issue Jul 30, 2020 · 1 comment · Fixed by #20389
Assignees
@leehinman
Labels
bug Filebeat Filebeat needs_backport PR is waiting to be backported to other branches. Team:Platforms Label for the Integrations - Platforms team

Comments

@leehinman
Copy link
Contributor

in x-pack/filebeat/input/azureeventhub/config.go the storage container name is built from the ephContainer & event hub name. But the event hub name can contain characters that are invalid for your storage containers.

A storage container name must be between 3 and 63 characters in length; start with a letter or number; and contain only letters, numbers, and the hyphen.

If the invalid character exists we get an error about resource containing invalid characters, and failure to get logs.
@leehinman leehinman added bug Filebeat Filebeat needs_backport PR is waiting to be backported to other branches. labels Jul 30, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 30, 2020
@leehinman leehinman self-assigned this Jul 30, 2020
@andresrc andresrc added the Team:Platforms Label for the Integrations - Platforms team label Jul 31, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 31, 2020
@leehinman leehinman mentioned this issue Jul 31, 2020
Merged
4 tasks
leehinman added a commit to leehinman/beats that referenced this issue Jul 31, 2020
@leehinman
Improve validation check for Azure configuration
44bf6bb 
A blob container name must be between 3 and 63 characters in length;
start with a letter or number; and contain only letters, numbers, and
the hyphen. All letters used in blob container names must be
lowercase.  Added validation to make sure the storage container name
meets those requirements.

Closes elastic#20369
leehinman added a commit that referenced this issue Aug 10, 2020
@leehinman
Improve validation check for Azure configuration (#20389)
7913005 
A blob container name must be between 3 and 63 characters in length;
start with a letter or number; and contain only letters, numbers, and
the hyphen. All letters used in blob container names must be
lowercase.  Added validation to make sure the storage container name
meets those requirements.

Closes #20369
@leehinman leehinman mentioned this issue Aug 10, 2020
Merged
4 tasks
leehinman added a commit to leehinman/beats that referenced this issue Aug 10, 2020
@leehinman
Improve validation check for Azure configuration (elastic#20389)
5381459 
A blob container name must be between 3 and 63 characters in length;
start with a letter or number; and contain only letters, numbers, and
the hyphen. All letters used in blob container names must be
lowercase.  Added validation to make sure the storage container name
meets those requirements.

Closes elastic#20369

(cherry picked from commit 7913005)
leehinman added a commit that referenced this issue Aug 10, 2020
@leehinman
Improve validation check for Azure configuration (#20389) (#20515)
8be5594 
A blob container name must be between 3 and 63 characters in length;
start with a letter or number; and contain only letters, numbers, and
the hyphen. All letters used in blob container names must be
lowercase.  Added validation to make sure the storage container name
meets those requirements.

Closes #20369

(cherry picked from commit 7913005)
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this issue Oct 14, 2020
@leehinman @melchiormoulin
Improve validation check for Azure configuration (elastic#20389)
b264c70 
A blob container name must be between 3 and 63 characters in length;
start with a letter or number; and contain only letters, numbers, and
the hyphen. All letters used in blob container names must be
lowercase.  Added validation to make sure the storage container name
meets those requirements.

Closes elastic#20369
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leehinman leehinman

Labels
bug Filebeat Filebeat needs_backport PR is waiting to be backported to other branches. Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Filebeat] Improve validation check for Azure configuration leehinman/beats
3 participants
@andresrc @elasticmachine @leehinman