[Agent] Make package fails when x-pack/agent is added to the BEATS'

[ph]

When the release-manager tries to run the make snapshot command and the agent is added to the list of beats in the Makefile. (BEATS?= ... x-pack/agent) The build will fail and complains that it cannot found the filebeat or metricbeat artifacts.

[elasticmachine]

Pinging @elastic/ingest-management (Project:fleet)

[ph]

Reproducable locally.

Error: failed building agent type=tar.gz for platform=darwin/amd64: failed adding file={Source:/home/ph/go/src/github.com/elastic/beats/x-pack/filebeat/build/distributions/filebeat-8.0.0-darwin-x86_64.tar.gz Content: Template: Target:beats/filebeat-8.0.0-darwin-x86_64.tar.gz Mode:-rw-r--r-- Config:false Modules:false Dep:<nil> Owner:} to tar: lstat /home/ph/go/src/github.com/elastic/beats/x-pack/filebeat/build/distributions/filebeat-8.0.0-darwin-x86_64.tar.gz: no such file or directory
failed building agent type=docker for platform=linux/amd64: failed to copy from /home/ph/go/src/github.com/elastic/beats/x-pack/filebeat/build/distributions/filebeat-8.0.0-linux-x86_64.tar.gz to build/package/agent/agent-linux-amd64.docker/docker-build/beat/beats/filebeat-8.0.0-linux-x86_64.tar.gz: copy failed: cannot stat source file /home/ph/go/src/github.com/elastic/beats/x-pack/filebeat/build/distributions/filebeat-8.0.0-linux-x86_64.tar.gz: stat /home/ph/go/src/github.com/elastic/beats/x-pack/filebeat/build/distributions/filebeat-8.0.0-linux-x86_64.tar.gz: no such file or directory
failed building agent type=rpm for platform=linux/386: failed adding file={Source:/home/ph/go/src/github.com/elastic/beats/x-pack/filebeat/build/distributions/filebeat-8.0.0-linux-x86.tar.gz Content: Template: Target:/etc/agent/beats/filebeat-8.0.0-linux-x86.tar.gz Mode:-rw-r--r-- Config:false Modules:false Dep:<nil> Owner:} to tar: lstat /home/ph/go/src/github.com/elastic/beats/x-pack/filebeat/build/distributions/filebeat-8.0.0-linux-x86.tar.gz: no such file or directory
failed building agent type=tar.gz for platform=linux/amd64: failed adding file={Source:/home/ph/go/src/github.com/elastic/beats/x-pack/filebeat/build/distributions/filebeat-8.0.0-linux-x86_64.tar.gz Content: Template: Target:beats/filebeat-8.0.0-linux-x86_64.tar.gz Mode:-rw-r--r-- Config:false Modules:false Dep:<nil> Owner:} to tar: lstat /home/ph/go/src/github.com/elastic/beats/x-pack/filebeat/build/distributions/filebeat-8.0.0-linux-x86_64.tar.gz: no such file or directory
failed building agent type=rpm for platform=linux/amd64: failed adding file={Source:/home/ph/go/src/github.com/elastic/beats/x-pack/metricbeat/build/distributions/metricbeat-8.0.0-linux-x86_64.tar.gz Content: Template: Target:/etc/agent/beats/metricbeat-8.0.0-linux-x86_64.tar.gz Mode:-rw-r--r-- Config:false Modules:false Dep:<nil> Owner:} to tar: lstat /home/ph/go/src/github.com/elastic/beats/x-pack/metricbeat/build/distributions/metricbeat-8.0.0-linux-x86_64.tar.gz: no such file or directory
failed building agent type=tar.gz for platform=linux/386: failed adding file={Source:/home/ph/go/src/github.com/elastic/beats/x-pack/filebeat/build/distributions/filebeat-8.0.0-linux-x86.tar.gz Content: Template: Target:beats/filebeat-8.0.0-linux-x86.tar.gz Mode:-rw-r--r-- Config:false Modules:false Dep:<nil> Owner:} to tar: lstat /home/ph/go/src/github.com/elastic/beats/x-pack/filebeat/build/distributions/filebeat-8.0.0-linux-x86.tar.gz: no such file or directory
failed building agent type=deb for platform=linux/386: failed adding file={Source:/home/ph/go/src/github.com/elastic/beats/x-pack/metricbeat/build/distributions/metricbeat-8.0.0-linux-x86.tar.gz Content: Template: Target:/etc/agent/beats/metricbeat-8.0.0-linux-x86.tar.gz Mode:-rw-r--r-- Config:false Modules:false Dep:<nil> Owner:} to tar: lstat /home/ph/go/src/github.com/elastic/beats/x-pack/metricbeat/build/distributions/metricbeat-8.0.0-linux-x86.tar.gz: no such file or directory
failed building agent type=zip for platform=windows/386: failed adding file=/home/ph/go/src/github.com/elastic/beats/x-pack/metricbeat/build/distributions/metricbeat-8.0.0-windows-x86.zip to zip: lstat /home/ph/go/src/github.com/elastic/beats/x-pack/metricbeat/build/distributions/metricbeat-8.0.0-windows-x86.zip: no such file or directory
failed building agent type=deb for platform=linux/amd64: failed adding file={Source:/home/ph/go/src/github.com/elastic/beats/x-pack/metricbeat/build/distributions/metricbeat-8.0.0-linux-x86_64.tar.gz Content: Template: Target:/etc/agent/beats/metricbeat-8.0.0-linux-x86_64.tar.gz Mode:-rw-r--r-- Config:false Modules:false Dep:<nil> Owner:} to tar: lstat /home/ph/go/src/github.com/elastic/beats/x-pack/metricbeat/build/distributions/metricbeat-8.0.0-linux-x86_64.tar.gz: no such file or directory
failed building agent type=zip for platform=windows/amd64: failed adding file=/home/ph/go/src/github.com/elastic/beats/x-pack/metricbeat/build/distributions/metricbeat-8.0.0-windows-x86_64.zip to zip: lstat /home/ph/go/src/github.com/elastic/beats/x-pack/metricbeat/build/distributions/metricbeat-8.0.0-windows-x86_64.zip: no such file or directory
make[2]: *** [../../dev-tools/make/xpack.mk:41: release] Error 1
make[2]: Leaving directory '/home/ph/go/src/github.com/elastic/beats/x-pack/agent'
make[1]: *** [Makefile:161: release] Error 1

[ph]

To make sure no one run into the same issues, it's because the path of the binary should also contains a "snapshot" like metricbeat-8.0.0-SNAPSHOT-darwin-x86_64.tar.gz

[ph]

As a note here, if you ever want to test again you may have to disable "mage packageBeatDashboard" this task doesn't use the BEATS? variable defined in the Makefile to limit what need to be build. This will save you a lot of time if you want to understand why a part of the build doesn't work.