Use pointer for OnConnectCallback

elastic · Oct 18, 2024 · 7bac99e · 7bac99e
1 parent c1134b7
commit 7bac99e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/libbeat/esleg/eslegclient/connection.go b/libbeat/esleg/eslegclient/connection.go
@@ -81,7 +81,7 @@ type ConnectionSettings struct {
 
 	Kerberos *kerberos.Config
 
-	OnConnectCallback func(Connection) error
+	OnConnectCallback func(*Connection) error
 	Observer          transport.IOStatser
 
 	Parameters       map[string]string
@@ -290,7 +290,7 @@ func (conn *Connection) Connect(ctx context.Context) error {
 	}
 
 	if conn.OnConnectCallback != nil {
-		if err := conn.OnConnectCallback(*conn); err != nil {
+		if err := conn.OnConnectCallback(conn); err != nil {
 			return fmt.Errorf("Connection marked as failed because the onConnect callback failed: %w", err)
 		}
 	}

diff --git a/libbeat/outputs/elasticsearch/client.go b/libbeat/outputs/elasticsearch/client.go
@@ -133,12 +133,12 @@ func NewClient(
 		return nil, err
 	}
 
-	conn.OnConnectCallback = func(conn eslegclient.Connection) error {
+	conn.OnConnectCallback = func(conn *eslegclient.Connection) error {
 		globalCallbackRegistry.mutex.Lock()
 		defer globalCallbackRegistry.mutex.Unlock()
 
 		for _, callback := range globalCallbackRegistry.callbacks {
-			err := callback(&conn)
+			err := callback(conn)
 			if err != nil {
 				return err
 			}
@@ -149,7 +149,7 @@ func NewClient(
 			defer onConnect.mutex.Unlock()
 
 			for _, callback := range onConnect.callbacks {
-				err := callback(&conn)
+				err := callback(conn)
 				if err != nil {
 					return err
 				}