-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Move to the elastic/goja fork instead of andrewkroh/goja. This the same code just moved into the elastic org and tagged with v2019-01-28+beats. For background, this fork contains a small change to goja that allows arbitrary map types (such as elastic's "MapStr" type) to be treated as javascript objects without requiring any conversion. Also note that since the time of the fork in 2019, there is now a path to accomplish this without a fork by implementing a `toValue(r *goja.Runtime) goja.Value` method on MapStr. It would mean introducing a direct dependency on goja. A tested example of can be found in the linked gist. https://gist.github.com/andrewkroh/19eccc0844bb935222914234c9510aa1 https://github.com/elastic/goja/releases/tag/v2019-01-28%2Bbeats (cherry picked from commit 8a7e9cf) Co-authored-by: Andrew Kroh <[email protected]>
- Loading branch information
1 parent
d183f58
commit 5411403
Showing
3 changed files
with
5 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12800,12 +12800,12 @@ Contents of probable licence file $GOMODCACHE/github.com/dolmen-go/contextio@v0. | |
|
||
|
||
-------------------------------------------------------------------------------- | ||
Dependency : github.com/andrewkroh/goja | ||
Dependency : github.com/elastic/goja | ||
Version: v0.0.0-20190128172624-dd2ac4456e20 | ||
Licence type (autodetected): MIT | ||
-------------------------------------------------------------------------------- | ||
|
||
Contents of probable licence file $GOMODCACHE/github.com/andrewkroh/[email protected]/LICENSE: | ||
Contents of probable licence file $GOMODCACHE/github.com/elastic/[email protected]/LICENSE: | ||
|
||
Copyright (c) 2016 Dmitry Panov | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters