Use a character not valid for kubernetes names to join values for uni…

…que UID
elastic · Feb 28, 2019 · 304bec5 · 304bec5
1 parent a3376e1
commit 304bec5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/metricbeat/module/kubernetes/util/metrics_cache.go b/metricbeat/module/kubernetes/util/metrics_cache.go
@@ -111,5 +111,5 @@ func (m *valueMap) Stop() {
 
 // ContainerUID creates an unique ID for from namespace, pod name and container name
 func ContainerUID(namespace, pod, container string) string {
-	return namespace + "-" + pod + "-" + container
+	return namespace + "/" + pod + "/" + container
 }
diff --git a/metricbeat/module/kubernetes/util/metrics_cache_test.go b/metricbeat/module/kubernetes/util/metrics_cache_test.go
@@ -47,5 +47,5 @@ func TestGetWithDefault(t *testing.T) {
 }
 
 func TestContainerUID(t *testing.T) {
-	assert.Equal(t, "a-b-c", ContainerUID("a", "b", "c"))
+	assert.Equal(t, "a/b/c", ContainerUID("a", "b", "c"))
 }