[metricbeat] gcp: check for nil metadata (#32281)

* add check for nil metadata * add changelog entry
elastic · Jun 1, 2023 · 14305c9 · 14305c9
1 parent e41073f
commit 14305c9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/CHANGELOG.next.asciidoc b/CHANGELOG.next.asciidoc
@@ -63,6 +63,7 @@ https://github.com/elastic/beats/compare/v8.2.0\...main[Check the HEAD diff]
 *Metricbeat*
 
 - update kubernetes apiserver metricset to not collect deprecated metrics and fix dashboard {pull}31973[31973]
+- Check for nil metadata in GCP. {pull}32281[32281]
 - update kubernetes controllermanager metricset to not collect deprecated metrics and fix dashboard {pull}32037[32037]
 - update elasticsearch node_stats metricset to use keyword for cgroup memory instead of long {pull}32197[32197]
 

diff --git a/x-pack/metricbeat/module/gcp/metrics/metricset.go b/x-pack/metricbeat/module/gcp/metrics/metricset.go
@@ -322,14 +322,16 @@ func (m *MetricSet) getMetadata(out *metric.MetricDescriptor, metricsWithMeta ma
 		ingestDelay:  0 * time.Second,
 	}
 
-	if out.Metadata.SamplePeriod != nil {
-		m.Logger().Debugf("For metric type %s: sample period = %s", out.Type, out.Metadata.SamplePeriod)
-		meta.samplePeriod = time.Duration(out.Metadata.SamplePeriod.Seconds) * time.Second
-	}
+	if out.Metadata != nil {
+		if out.Metadata.SamplePeriod != nil {
+			m.Logger().Debugf("For metric type %s: sample period = %s", out.Type, out.Metadata.SamplePeriod)
+			meta.samplePeriod = time.Duration(out.Metadata.SamplePeriod.Seconds) * time.Second
+		}
 
-	if out.Metadata.IngestDelay != nil {
-		m.Logger().Debugf("For metric type %s: ingest delay = %s", out.Type, out.Metadata.IngestDelay)
-		meta.ingestDelay = time.Duration(out.Metadata.IngestDelay.Seconds) * time.Second
+		if out.Metadata.IngestDelay != nil {
+			m.Logger().Debugf("For metric type %s: ingest delay = %s", out.Type, out.Metadata.IngestDelay)
+			meta.ingestDelay = time.Duration(out.Metadata.IngestDelay.Seconds) * time.Second
+		}
 	}
 
 	metricsWithMeta[out.Type] = meta