Skip to content

Commit

Permalink
Fix bdist during installation of Python requirements (#18745)
Browse files Browse the repository at this point in the history
* Fix bdist/wheel errors on build

* Use independent args

* Formatting

* Remove -r

* Collapse into single line

* Update dev-tools/mage/pytest.go

Co-authored-by: Andrew Kroh <[email protected]>

Co-authored-by: Andrew Kroh <[email protected]>
  • Loading branch information
cachedout and andrewkroh authored Jun 8, 2020
1 parent c01dfe6 commit 10a2ce9
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions dev-tools/mage/pytest.go
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,11 @@ func PythonVirtualenv() (string, error) {
args = append(args, "-Ur", req)
}

// First ensure that wheel is installed so that bdists build cleanly.
if err = sh.RunWith(env, pip, "install", "-U", "wheel"); err != nil {
return "", err
}

// Execute pip to install the dependencies.
if err := sh.RunWith(env, pip, args...); err != nil {
return "", err
Expand Down

0 comments on commit 10a2ce9

Please sign in to comment.