Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove apm #219

Merged
merged 77 commits into from
Mar 31, 2023
Merged

remove apm #219

merged 77 commits into from
Mar 31, 2023

Conversation

jlind23
Copy link
Contributor

@jlind23 jlind23 commented Feb 2, 2023

No description provided.

@jlind23
Copy link
Contributor Author

jlind23 commented Feb 2, 2023

/test

@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 2, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-31T09:27:36.751+0000

  • Duration: 31 min 40 sec

Test stats 🧪

Test Results
Failed 0
Passed 4191
Skipped 3773
Total 7964

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@jlind23
Copy link
Contributor Author

jlind23 commented Feb 2, 2023

/test

@jlind23
Copy link
Contributor Author

jlind23 commented Feb 2, 2023

/test

1 similar comment
@jlind23
Copy link
Contributor Author

jlind23 commented Feb 2, 2023

/test

@jlind23 jlind23 closed this Feb 2, 2023
@jlind23 jlind23 reopened this Feb 2, 2023
@jlind23
Copy link
Contributor Author

jlind23 commented Feb 2, 2023

/test

@jlind23
Copy link
Contributor Author

jlind23 commented Feb 10, 2023

/test

@jlind23 jlind23 closed this Feb 10, 2023
@jlind23 jlind23 reopened this Feb 10, 2023
@jlind23
Copy link
Contributor Author

jlind23 commented Feb 10, 2023

/jenkins test this please

@jlind23
Copy link
Contributor Author

jlind23 commented Feb 10, 2023

/jenkins run please

@jlind23
Copy link
Contributor Author

jlind23 commented Feb 10, 2023

run please

@andrewkroh
Copy link
Member

Is there any known issue on your end related to this? Shouldn't I take the easy path and remove Centos-8 from the used OS for Packetbeat?

There's no known issues with CentOS 8 and Packetbeat. So to unblock this, skipping that combo of Packetbeat on CentOS 8 sounds good. Then if the rest is back to green I can try to renabled it at some point and debug what's failing.

@jlind23 jlind23 requested review from v1v and andrewkroh March 31, 2023 08:28
@jlind23
Copy link
Contributor Author

jlind23 commented Mar 31, 2023

@andrewkroh @v1v can I please have your review on this? I had to remove/change a bunch of tests due to recent changes/limitations that were added over the past 6 Months. (Yes these tests have been failing for more than 6 months..)

Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor comment to remove a couple of my commits :)

hosts Show resolved Hide resolved
roles/common/tasks/main.yml Outdated Show resolved Hide resolved
@jlind23
Copy link
Contributor Author

jlind23 commented Mar 31, 2023

Thanks @v1v I also cleaned up a couple of debug statement I added.

@jlind23 jlind23 merged commit d30a88c into main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants