Adapt output file name to latest beats changes. #212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the tests for beats when checking for the output files. Relates to changes from elastic/beats#28927 Add output ndjson suffix to APM Server output (unclear why this is necessary). * Increase timeout for output file and ensure it is written. The output file is only written when some actual values are processed. Enable self-instrumentation for APM to ensure the output file is written and increase timeout. For beats, enable metrics logging explicitly. * Disable failing beats issues A follow up is necessary to fix and enable these tests if still useful.
|
@kvch Would be nice to get your review on this change as you were driving the file renames if I remember correctly. |
|
Closing this as outdated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is supposed to fix the tests for beats and apm-server when checking for the output files.
fixes #211