chore: remove assertions related to output files

elastic · Dec 2, 2021 · 4254564 · 4254564
1 parent 7971ca7
commit 4254564
Show file tree

Hide file tree

Showing 8 changed files with 1 addition and 256 deletions.
diff --git a/roles/test-beat/tasks/auditbeat/assert.yml b/roles/test-beat/tasks/auditbeat/assert.yml
diff --git a/roles/test-beat/tasks/common/assert.yml b/roles/test-beat/tasks/common/assert.yml
@@ -1,20 +1,5 @@
 ---
 
-- name: 'Stat {{ beat_name }} output file'
-  stat:
-    path: '{{ beat_output_file }}'
-  register: output_stat
-
-- name: '{{ beat_name }} output file stats'
-  debug:
-    var: output_stat
-
-- name: "Assert that {{ beat_name }} output file exists"
-  assert:
-    that:
-      - "output_stat.stat.exists"
-      - "output_stat.stat.size > 0"
-
 - name: 'Stat {{ beat_name }} log file'
   stat:
     path: '{{ beat_log_file }}'

diff --git a/roles/test-beat/tasks/darwin/main.yml b/roles/test-beat/tasks/darwin/main.yml
@@ -46,12 +46,6 @@
   loop_control:
     loop_var: post_run_item
 
-- name: 'Wait for {{ beat_service_name }} to produce output.json'
-  wait_for:
-    path: '{{ beat_output_file }}'
-    search_regex: '"version"'
-    timeout: 20
-
 - name: 'Fetch metrics from {{ beat_name }} over HTTP'
   get_url:
     url: http://localhost:5066/stats

diff --git a/roles/test-beat/tasks/linux/main.yml b/roles/test-beat/tasks/linux/main.yml
@@ -51,12 +51,6 @@
   loop_control:
     loop_var: post_run_item
 
-- name: 'Wait for {{ beat_name }} to produce output.json'
-  wait_for:
-    path: '{{ beat_output_file }}'
-    search_regex: '"version"'
-    timeout: 20
-
 - name: 'Fetch metrics from {{ beat_name }} over HTTP'
   get_url:
     url: http://localhost:5066/stats

diff --git a/roles/test-beat/tasks/main.yml b/roles/test-beat/tasks/main.yml
@@ -22,10 +22,9 @@
     - 'vars/{{ ansible_system | lower }}.yml'
     - default.yml
 
-- name: Set config/output/log file vars
+- name: Set config/log file vars
   set_fact:
     beat_config_file: '{{ beat_config_path}}/{{ beat_name }}.yml'
-    beat_output_file: '{{ beat_logs_path }}/output.json'
     beat_log_file: '{{ beat_logs_path }}/{{ beat_name }}.json'
     beat_registry_file: '{{ beat_data_path }}/{{ registry_file }}'
     beat_metrics_file: '{{ beat_logs_path }}/metrics.json'
@@ -48,12 +47,6 @@
       loop_var: system_item
 
   always:
-  - name: Save output to host
-    fetch:
-      src: '{{ beat_output_file }}'
-      dest: 'logs/{{ beat_name }}{{ beat_pkg_suffix }}-{{ win_arch | default(ansible_architecture) }}-{{ inventory_hostname }}/output.json'
-      flat: yes
-
   - name: Save log to host
     fetch:
       src: '{{ beat_log_file }}'
@@ -89,11 +82,3 @@
   loop_control:
     loop_var: assert_item
 
-- name: Run {{ beat_name }} assertions on outputs
-  include: '{{ beat_assert_item }}'
-  with_first_found:
-  - files:
-    - '{{ beat_name }}/assert.yml'
-    - default.yml
-  loop_control:
-    loop_var: beat_assert_item
diff --git a/roles/test-beat/tasks/packetbeat/assert.yml b/roles/test-beat/tasks/packetbeat/assert.yml
diff --git a/roles/test-beat/tasks/win32nt/assert.yml b/roles/test-beat/tasks/win32nt/assert.yml
diff --git a/roles/test-beat/tasks/winlogbeat/assert.yml b/roles/test-beat/tasks/winlogbeat/assert.yml