Update powershell command for hostname detection to avoid profiles and logo that could break detection #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d logo that could break detection If a Windows system has a powershell profile that emits output, then it could pollute the output used to read the hostname value. Likewise with the powershell logo output, though I don't know if/when that logo appears -- it does not in apm-agent-nodejs' CI tests. Refs: elastic/apm-agent-nodejs#3899
|
@SylvainJuge I think the Node.js and Java agents are the only ones that use this powershell command in their code for Windows hostname detection. |
3 tasks
|
I've opened a draft PR to implement this in the Java agent : elastic/apm-agent-java#3556, if adding those extra parameters do not cause a regression that's probably enough for us to merge it and validate this spec change (unless you have a better way to test for it). |
SylvainJuge
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a Windows system has a powershell profile that emits output, then it
could pollute the output used to read the hostname value. Likewise with
the powershell logo output, though I don't know if/when that logo
appears -- it does not in apm-agent-nodejs' CI tests.
Refs: elastic/apm-agent-nodejs#3899
Powershell CLI options are documented here: https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_powershell_exe?view=powershell-5.1