Clarify lambda capturing of SQS and SNS message attributes #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
|
trentm
added a commit
to elastic/apm-agent-nodejs
that referenced
this pull request
Mar 10, 2022
… attributes for lambda transaction - If a SNS or SQS single event trigger to an instrumented Lambda function includes message attributes with the name "traceparent" (and "tracestate"), case-insensitive, then those are used to continue the trace. This was already being done for API Gateway event headers. - Also, fix a bug in the capturing of SNS and SQS message attributes as "transaction.context.message.headers". Note that only "String"-type message attributes are captured. Binary-type attributes are base64 encoded. I'm not sure of the value in capturing them. Closes: #1831 Fixes: #2605 Refs: elastic/apm#614
3 tasks
|
@trentm Great catch! In general: I think it's OK to ignore For Java:
@basepi Let's fix the bug Trent mentioned above for the Python agent as part of the current lambda improvements. |
basepi
approved these changes
Mar 10, 2022
AlexanderWert
approved these changes
Mar 11, 2022
basepi
approved these changes
Mar 15, 2022
trentm
added a commit
to elastic/apm-agent-nodejs
that referenced
this pull request
Mar 15, 2022
… attributes for lambda transaction (#2606) - If a SNS or SQS single event trigger to an instrumented Lambda function includes message attributes with the name "traceparent" (and "tracestate"), case-insensitive, then those are used to continue the trace. This was already being done for API Gateway event headers. - Also, fix a bug in the capturing of SNS and SQS message attributes as "transaction.context.message.headers". Note that only "String"-type message attributes are captured. Binary-type attributes are base64 encoded. I'm not sure of the value in capturing them. Closes: #1831 Fixes: #2605 Refs: elastic/apm#614
SylvainJuge
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
elastic/apm-agent-nodejs#2605 shows that just setting
transaction.context.message.headers = sqsRecord.messageAttributesis wrong, becausemessageAttributesfor both SNS and SQS events have a different structure than is expected. Currently the spec just says:This change attempts to clarify that the
messageAttributesfields in the event cannot be used directly..getValue()at https://github.com/elastic/apm-agent-java/blob/198cfac574fcbaae2d9a374702637bbcf44c46f8/apm-agent-plugins/apm-awslambda-plugin/src/main/java/co/elastic/apm/agent/awslambda/SNSMessageAttributesGetter.java#L39, for example, is doing with message attributes of type "Binary".Checklist for a small enhancement
CODEOWNERS)To auto-merge the PR, add
/schedule YYYY-MM-DDto the PR description.