Store outcome values in servicemetrics transaction.success_count
#9791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not have a backport label. Could you fix it @carsonip? 🙏
NOTE: |
mergify
bot
added
the
backport-skip
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
carsonip
force-pushed
the
service-metrics-transaction-success-count
branch
4 times, most recently
from
17a0479 to
9331523
Compare
carsonip
commented
Dec 12, 2022
| @@ -115,8 +112,8 @@ func (e *Transaction) fields() mapstr.M { | |||
| if e.FailureCount != 0 { | |||
| transaction.set("failure_count", e.FailureCount) | |||
| } | |||
| if e.SuccessCount != 0 { | |||
| transaction.set("success_count", e.SuccessCount) | |||
| if e.SuccessCount.Count != 0 { | |||
There was a problem hiding this comment.
Should success_count be omitted from output if Count is zero? e.g. when it only contains unknown outcome transactions.
There was a problem hiding this comment.
If it is not omitted on count=0, transaction.success_count will have to be a pointer to SummaryMetric, otherwise any event that contains the transaction field will have transaction.success_count.sum: 0 and transaction.success_count.count: 0
There was a problem hiding this comment.
I think omitting when count is zero is the way to go.
carsonip
force-pushed
the
service-metrics-transaction-success-count
branch
4 times, most recently
from
356ab25 to
96c6544
Compare
carsonip
changed the title
📚 Go benchmark reportDiff with the report generated with https://pkg.go.dev/golang.org/x/perf/cmd/benchstat |
carsonip
changed the title
transaction.success_count
carsonip
changed the title
transaction.success_counttransaction.success_count
axw
approved these changes
Dec 13, 2022
There was a problem hiding this comment.
Looks good! We might need to do it for transaction metrics & events too, based on #5243 (comment). That can be another PR (or two), so maybe just remove the "Closes" from the description and follow up?
|
Changed from "closes" to "related to". Rebasing. |
carsonip
force-pushed
the
service-metrics-transaction-success-count
branch
from
38efcdf to
aa4c5a0
Compare
This was referenced Dec 13, 2022
|
Tested with 8.7.0 BC2 on ESS, ended up asserting that package main
import (
"fmt"
"time"
"go.elastic.co/apm/v2"
)
func main() {
tracer := apm.DefaultTracer()
tracer.SetSpanCompressionEnabled(false) // Disable compression.
tracer.SetExitSpanMinDuration(2 * time.Millisecond) // set duration to 2ms.
for i := 0; i < 10_000; i++ {
for _, duration := range []time.Duration{100, 1000} {
tx := tracer.StartTransaction(fmt.Sprintf("tx-%d", i), fmt.Sprintf("type-%d", i))
tx.Duration = time.Duration(duration) * time.Millisecond
if i%2 == 0 {
tx.Outcome = "success"
} else {
tx.Outcome = "failure"
}
tx.End()
if i%800 == 0 {
tracer.Flush(nil)
}
}
}
tracer.Flush(nil)
fmt.Printf("%+v\n", tracer.Stats())
}#!/bin/bash
export ELASTIC_APM_SERVER_URL=${1:-"http://localhost:8200"}
export ELASTIC_APM_GLOBAL_LABELS=department_name=apm,organization=observability,company=elastic
export ELASTIC_APM_SERVICE_NAME=apm
go run main.go
export ELASTIC_APM_GLOBAL_LABELS=department_name=fleet-server,organization=observability,company=elastic
export ELASTIC_APM_SERVICE_NAME=fleet-server
go run main.go
export ELASTIC_APM_GLOBAL_LABELS=department_name=kibana,organization=platform,company=elastic
export ELASTIC_APM_SERVICE_NAME=kibana
go run main.gosuccessfailure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
For service metrics, use field
transaction.success_countto store the transaction success and failure counts for easier avg aggregation on the field.Checklist
apmpackagehave been made)How to test these changes
transaction.success_countis populated correctlytransaction.success_countRelated issues
Related to #5243