-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
smoke: Remove usage of artifacts API #9233
smoke: Remove usage of artifacts API #9233
Conversation
Removes the usage of the Elastic artifacts API, in favor of using the Elastic Cloud API to obtain all the stack pack versions available in the configured ESS region. This approach is better than using the artifacts API for two reasons: 1. Artifacts API and ESS regions may have different stack packs 2. Unused artifacts are removed after 30 days. By using the ESS API, we no longer will see failures due to a missing BC or old versions removed (or the `7.17.x` older versions). Last, it also adds the `SKIP_DESTROY` conditional to all the `test.sh` scrits. Signed-off-by: Marc Lopez Rubio <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! LGTM.
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
|
📚 Go benchmark reportDiff with the
report generated with https://pkg.go.dev/golang.org/x/perf/cmd/benchstat |
…ored * upstream/main: smoke: Remove usage of artifacts API (elastic#9233) Update to elastic/beats@77e4e30df6e2 (elastic#9227) Enable synthetic source for metrics data streams (elastic#9215) testing/rally: add force-merge operation (elastic#9226) Make ecs.version a constant_keyword field (elastic#9208)
Motivation/summary
Removes the usage of the Elastic artifacts API, in favor of using the Elastic Cloud API to obtain all the stack pack versions available in the configured ESS region.
This approach is better than using the artifacts API for two reasons:
By using the ESS API, we no longer will see failures due to a missing BC or old versions removed (or the
7.17.x
older versions).Last, it also adds the
SKIP_DESTROY
conditional to all thetest.sh
scripts.Checklist
- [ ] Update CHANGELOG.asciidoc- [ ] Update package changelog.yml (only if changes toapmpackage
have been made)- [ ] Documentation has been updatedHow to test these changes
Run smoke tests for version
7.17
:make smoketest/all SMOKETEST_VERSIONS=7.17
Related issues
Supersedes ##9225