Update beats to bd6981d #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Important changes / additions: * Add support for cloud id. See elastic/beats#4964 for more details. This could simplify the onboard for users that use apm-server with the Cloud in the future. * Be able to overwrite index pattern in the index template. See elastic/beats#4769 for more details. This allows to clean up our system tests.
simitt
reviewed
Aug 24, 2017
| # The template name and pattern has to be set in case the elasticsearch index pattern is modified. | ||
| #setup.template.name: "apm-server-%{[beat.version]}" | ||
|
|
||
| # Template patttern. By default the template patter is "-%{[beat.version]}-*" to apply to the default index settings. |
There was a problem hiding this comment.
typo
the template patter is..
There was a problem hiding this comment.
That is a typo I need to fix on the beats side.
| # The version of the beat will always be appended to the given name | ||
| # so the final name is apm-server-%{[beat.version]}. | ||
| #setup.template.name: "apm-server" | ||
| # Template name. By default the template name is "apm-server-%{[beat.version]}" |
There was a problem hiding this comment.
should we keep havig. beat.version here or change to apmserver.version?
There was a problem hiding this comment.
The fields used here must be part of the event. We have beat.version but we don't have apm-server.version in our events.
|
@simitt For updating _beats: Yes Our use case for overwriting the index pattern name is for testing. On the beats side especially for logging people create their own templates. But in general it's only expert users that do this and I would not expect it to happen on the apm-server side at first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important Changes / Additions: