Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ironbank image product name #8959

Merged
merged 2 commits into from
Aug 25, 2022
Merged

update ironbank image product name #8959

merged 2 commits into from
Aug 25, 2022

Conversation

jmlrt
Copy link
Member

@jmlrt jmlrt commented Aug 24, 2022

Motivation/summary

This is required to automate the creation of the ironbank merge requests as the ubireleaser is using this field to compute the apm-server artifact url. For example it is now trying to retrieve https://artifacts.elastic.co/downloads/beats/apm-server-8.4.0-linux-x86_64.tar.gz instead of https://artifacts.elastic.co/downloads/apm-server/apm-server-8.4.0-linux-x86_64.tar.gz

Related issues

#8537

This is required to automate the creation of the ironbank merge requests as the ubireleaser is using this field to compute the apm-server artifact url. For example it is now trying to retrieve https://artifacts.elastic.co/downloads/beats/apm-server-8.4.0-linux-x86_64.tar.gz instead of https://artifacts.elastic.co/downloads/apm-server/apm-server-8.4.0-linux-x86_64.tar.gz
@jmlrt jmlrt requested a review from v1v August 24, 2022 16:32
@mergify
Copy link
Contributor

mergify bot commented Aug 24, 2022

This pull request does not have a backport label. Could you fix it @jmlrt? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.x is the label to automatically backport to the 7.x branch.
  • backport-7./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Aug 24, 2022
@jmlrt jmlrt added backport-7.x Backport PR to the 7.x branch backport-7.17 Automated backport with mergify to the 7.17 branch backport-8.4 Automated backport with mergify labels Aug 24, 2022
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Aug 24, 2022
@jmlrt jmlrt added automation and removed backport-7.x Backport PR to the 7.x branch labels Aug 24, 2022
@jmlrt jmlrt requested a review from cachedout August 24, 2022 16:34
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks Julien

@apmmachine
Copy link
Contributor

apmmachine commented Aug 24, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-25T01:00:43.046+0000

  • Duration: 26 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 129
Skipped 0
Total 129

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate and publish the docker images.

  • /test windows : Build & tests on Windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@apmmachine
Copy link
Contributor

apmmachine commented Aug 24, 2022

📚 Go benchmark report

Diff with the main branch

name                                                                                              old time/op    new time/op     delta
pkg:github.com/elastic/apm-server/internal/agentcfg goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/decoder goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/model/modelindexer goos:linux goarch:amd64
ModelIndexer/NoCompression-12                                                                       2.20µs ± 9%     1.78µs ±35%   -19.14%  (p=0.016 n=5+5)
ModelIndexer/BestCompression-12                                                                     16.1µs ±30%      9.8µs ±13%   -38.92%  (p=0.008 n=5+5)
pkg:github.com/elastic/apm-server/internal/processor/stream goos:linux goarch:amd64
RUMV3Processor-12                                                                                   0.00ns ± 9%     0.00ns ±46%  +122.46%  (p=0.016 n=4+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/metadata.ndjson-12                      4.52µs ± 4%     4.32µs ± 2%    -4.49%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/ratelimit.ndjson-12                     44.2µs ± 3%     40.5µs ±15%    -8.27%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/transactions.ndjson-12                  34.6µs ± 5%     30.9µs ± 2%   -10.71%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/invalid-json-metadata.ndjson-12         2.23µs ± 1%     2.26µs ± 0%    +1.37%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/transactions.ndjson-12                  15.1µs ± 1%     15.5µs ± 1%    +2.91%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/transactions_spans.ndjson-12            18.5µs ± 0%     19.2µs ± 1%    +3.62%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/transactions_spans_rum.ndjson-12        2.61µs ± 1%     2.73µs ± 3%    +4.41%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/transactions_spans_rum_2.ndjson-12      2.54µs ± 1%     2.62µs ± 2%    +3.40%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/unknown-span-type.ndjson-12             7.90µs ± 1%     8.28µs ± 1%    +4.82%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/errors.ndjson-12                      10.2µs ± 4%     10.9µs ± 1%    +6.41%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/errors_transaction_id.ndjson-12       5.58µs ± 2%     5.81µs ± 2%    +4.16%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/events.ndjson-12                      15.2µs ± 1%     15.7µs ± 1%    +3.25%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/invalid-event-type.ndjson-12           769ns ± 1%      787ns ± 1%    +2.36%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/invalid-event.ndjson-12               3.51µs ± 1%     3.58µs ± 1%    +2.15%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/invalid-json-metadata.ndjson-12       1.91µs ± 0%     1.97µs ± 1%    +2.84%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/invalid-metadata-2.ndjson-12           477ns ± 1%      486ns ± 1%    +1.76%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/metadata-null-values.ndjson-12         963ns ± 2%      998ns ± 3%    +3.63%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/metadata.ndjson-12                    1.25µs ± 1%     1.28µs ± 1%    +2.44%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/metricsets.ndjson-12                  6.01µs ± 1%     6.16µs ± 2%    +2.58%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/minimal-service.ndjson-12             1.68µs ± 1%     1.74µs ± 2%    +3.59%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/optional-timestamps.ndjson-12         3.03µs ± 1%     3.09µs ± 1%    +1.81%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/otel-bridge.ndjson-12                 3.80µs ± 1%     3.89µs ± 2%    +2.40%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/ratelimit.ndjson-12                   16.3µs ± 1%     16.7µs ± 1%    +2.17%  (p=0.024 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/spans.ndjson-12                       15.3µs ± 1%     15.9µs ± 3%    +4.01%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/transactions-huge_traces.ndjson-12    4.81µs ± 0%     4.93µs ± 2%    +2.46%  (p=0.016 n=4+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/transactions.ndjson-12                12.8µs ± 1%     13.2µs ± 1%    +3.36%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/transactions_spans.ndjson-12          15.9µs ± 1%     16.4µs ± 1%    +2.73%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/transactions_spans_rum.ndjson-12      2.20µs ± 1%     2.26µs ± 1%    +2.90%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/transactions_spans_rum_2.ndjson-12    2.15µs ± 1%     2.19µs ± 0%    +2.11%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/unknown-span-type.ndjson-12           6.77µs ± 1%     7.16µs ± 5%    +5.77%  (p=0.008 n=5+5)
pkg:github.com/elastic/apm-server/internal/publish goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/spanmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/txmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling/eventstorage goos:linux goarch:amd64
WriteTransaction/json_codec-12                                                                      4.51µs ±11%     4.09µs ±11%    -9.40%  (p=0.032 n=5+5)
ReadEvents/json_codec/199_events-12                                                                 1.45ms ± 0%     1.44ms ± 1%    -0.87%  (p=0.016 n=4+5)
IsTraceSampled/unsampled-12                                                                         71.1ns ± 2%     70.0ns ± 1%    -1.56%  (p=0.032 n=5+5)

name                                                                                              old alloc/op   new alloc/op    delta
pkg:github.com/elastic/apm-server/internal/agentcfg goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/decoder goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/model/modelindexer goos:linux goarch:amd64
ModelIndexer/NoCompression-12                                                                       3.33kB ± 1%     3.26kB ± 2%    -2.19%  (p=0.016 n=5+5)
pkg:github.com/elastic/apm-server/internal/processor/stream goos:linux goarch:amd64
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/invalid-metadata.ndjson-12              3.22kB ± 1%     3.14kB ± 1%    -2.29%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/invalid-json-metadata.ndjson-12         5.92kB ± 1%     5.81kB ± 2%    -1.85%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/minimal-service.ndjson-12               11.9kB ± 0%     11.9kB ± 0%    -0.38%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/optional-timestamps.ndjson-12           21.6kB ± 1%     21.7kB ± 1%    +0.67%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/metricsets.ndjson-12                  32.3kB ± 0%     32.1kB ± 0%    -0.74%  (p=0.016 n=4+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/unknown-span-type.ndjson-12           24.7kB ± 1%     24.5kB ± 1%    -0.64%  (p=0.040 n=5+5)
pkg:github.com/elastic/apm-server/internal/publish goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/spanmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/txmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling/eventstorage goos:linux goarch:amd64

name                                                                                              old allocs/op  new allocs/op   delta
pkg:github.com/elastic/apm-server/internal/agentcfg goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/decoder goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/model/modelindexer goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/processor/stream goos:linux goarch:amd64
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/heavy.ndjson-12                          27.3k ± 0%      27.3k ± 0%    +0.01%  (p=0.048 n=5+5)
pkg:github.com/elastic/apm-server/internal/publish goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/spanmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/txmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling/eventstorage goos:linux goarch:amd64

name                                                                                              old speed      new speed       delta
pkg:github.com/elastic/apm-server/internal/processor/stream goos:linux goarch:amd64
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/metadata.ndjson-12                     275MB/s ± 4%    288MB/s ± 2%    +4.61%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/ratelimit.ndjson-12                   95.3MB/s ± 3%  104.6MB/s ±17%    +9.73%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/transactions.ndjson-12                 163MB/s ± 5%    183MB/s ± 2%   +11.89%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/invalid-json-metadata.ndjson-12        201MB/s ± 1%    198MB/s ± 0%    -1.34%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/transactions.ndjson-12                 375MB/s ± 1%    365MB/s ± 1%    -2.82%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/transactions_spans.ndjson-12           314MB/s ± 0%    303MB/s ± 1%    -3.50%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/transactions_spans_rum.ndjson-12       442MB/s ± 1%    423MB/s ± 3%    -4.21%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/transactions_spans_rum_2.ndjson-12     440MB/s ± 1%    426MB/s ± 2%    -3.27%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/unknown-span-type.ndjson-12            418MB/s ± 1%    399MB/s ± 1%    -4.61%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/errors.ndjson-12                     622MB/s ± 4%    584MB/s ± 1%    -6.08%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/errors_transaction_id.ndjson-12      685MB/s ± 2%    658MB/s ± 2%    -3.98%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/events.ndjson-12                     489MB/s ± 1%    474MB/s ± 1%    -3.15%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/invalid-event-type.ndjson-12         509MB/s ± 1%    497MB/s ± 1%    -2.31%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/invalid-event.ndjson-12              218MB/s ± 1%    214MB/s ± 1%    -2.11%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/invalid-json-metadata.ndjson-12      234MB/s ± 1%    227MB/s ± 1%    -2.76%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/invalid-metadata-2.ndjson-12         914MB/s ± 1%    898MB/s ± 1%    -1.73%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/metadata-null-values.ndjson-12       547MB/s ± 2%    528MB/s ± 3%    -3.48%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/metadata.ndjson-12                  1.00GB/s ± 1%   0.97GB/s ± 1%    -2.39%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/metricsets.ndjson-12                 424MB/s ± 1%    413MB/s ± 2%    -2.51%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/minimal-service.ndjson-12            253MB/s ± 1%    244MB/s ± 2%    -3.46%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/optional-timestamps.ndjson-12        339MB/s ± 1%    333MB/s ± 1%    -1.77%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/otel-bridge.ndjson-12                495MB/s ± 1%    484MB/s ± 2%    -2.33%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/ratelimit.ndjson-12                  258MB/s ± 1%    252MB/s ± 1%    -2.12%  (p=0.024 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/spans.ndjson-12                      526MB/s ± 1%    505MB/s ± 3%    -3.83%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/transactions-huge_traces.ndjson-12   659MB/s ± 0%    643MB/s ± 2%    -2.39%  (p=0.016 n=4+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/transactions.ndjson-12               442MB/s ± 1%    428MB/s ± 1%    -3.25%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/transactions_spans.ndjson-12         365MB/s ± 1%    355MB/s ± 1%    -2.66%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/transactions_spans_rum.ndjson-12     526MB/s ± 1%    511MB/s ± 1%    -2.82%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/transactions_spans_rum_2.ndjson-12   521MB/s ± 1%    510MB/s ± 0%    -2.08%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/unknown-span-type.ndjson-12          489MB/s ± 1%    462MB/s ± 5%    -5.36%  (p=0.008 n=5+5)

report generated with https://pkg.go.dev/golang.org/x/perf/cmd/benchstat

@axw axw enabled auto-merge (squash) August 25, 2022 01:00
@axw axw merged commit e751054 into main Aug 25, 2022
@axw axw deleted the ironbank-product-name branch August 25, 2022 01:27
mergify bot pushed a commit that referenced this pull request Aug 25, 2022
This is required to automate the creation of the ironbank merge requests as the ubireleaser is using this field to compute the apm-server artifact url. For example it is now trying to retrieve https://artifacts.elastic.co/downloads/beats/apm-server-8.4.0-linux-x86_64.tar.gz instead of https://artifacts.elastic.co/downloads/apm-server/apm-server-8.4.0-linux-x86_64.tar.gz

Co-authored-by: Andrew Wilkins <[email protected]>
(cherry picked from commit e751054)
mergify bot pushed a commit that referenced this pull request Aug 25, 2022
This is required to automate the creation of the ironbank merge requests as the ubireleaser is using this field to compute the apm-server artifact url. For example it is now trying to retrieve https://artifacts.elastic.co/downloads/beats/apm-server-8.4.0-linux-x86_64.tar.gz instead of https://artifacts.elastic.co/downloads/apm-server/apm-server-8.4.0-linux-x86_64.tar.gz

Co-authored-by: Andrew Wilkins <[email protected]>
(cherry picked from commit e751054)
axw pushed a commit that referenced this pull request Aug 25, 2022
This is required to automate the creation of the ironbank merge requests as the ubireleaser is using this field to compute the apm-server artifact url. For example it is now trying to retrieve https://artifacts.elastic.co/downloads/beats/apm-server-8.4.0-linux-x86_64.tar.gz instead of https://artifacts.elastic.co/downloads/apm-server/apm-server-8.4.0-linux-x86_64.tar.gz

Co-authored-by: Andrew Wilkins <[email protected]>
(cherry picked from commit e751054)

Co-authored-by: Julien Mailleret <[email protected]>
axw pushed a commit that referenced this pull request Aug 25, 2022
This is required to automate the creation of the ironbank merge requests as the ubireleaser is using this field to compute the apm-server artifact url. For example it is now trying to retrieve https://artifacts.elastic.co/downloads/beats/apm-server-8.4.0-linux-x86_64.tar.gz instead of https://artifacts.elastic.co/downloads/apm-server/apm-server-8.4.0-linux-x86_64.tar.gz

Co-authored-by: Andrew Wilkins <[email protected]>
(cherry picked from commit e751054)

Co-authored-by: Julien Mailleret <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation backport-7.17 Automated backport with mergify to the 7.17 branch backport-8.4 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants