makes timestamp optional #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roncohen
reviewed
Apr 9, 2018
processor/transaction/payload.go
Outdated
| @@ -65,6 +67,10 @@ func (pa *payload) transform(config config.Config) []beat.Event { | |||
|
|
|||
| var events []beat.Event | |||
| for _, event := range pa.Events { | |||
| var zeroTime = time.Time{} | |||
| if event.Timestamp == zeroTime { | |||
There was a problem hiding this comment.
Looks like this IsZero method could be useful here: https://golang.org/pkg/time/#Time.IsZero
simitt
requested changes
Apr 9, 2018
utility/data_fetcher.go
Outdated
| @@ -145,6 +145,9 @@ func (d *ManualDecoder) MapStr(base map[string]interface{}, key string, keys ... | |||
|
|
|||
| func (d *ManualDecoder) TimeRFC3339(base map[string]interface{}, key string, keys ...string) time.Time { | |||
| val := getDeep(base, keys...)[key] | |||
| if val == nil { | |||
| return time.Time{} | |||
There was a problem hiding this comment.
How about introducing a TimeRFC3339WithDefault method that returns a time.Now() instead of a zero time in case it is empty? The decoding happens before the transformation, so the timestamp would be more accurate, and no further handling in the transform function would be needed.
simitt
approved these changes
Apr 11, 2018
jalvz
force-pushed
the
optional-timestamp
branch
from
d47e7b1 to
8564f95
Compare
jalvz
added a commit
to jalvz/apm-server
that referenced
this pull request
Apr 12, 2018
jalvz
added a commit
that referenced
this pull request
Apr 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #723