Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overrides timestamps coming from frontend agents #792

Closed
wants to merge 1 commit into from

Conversation

jalvz
Copy link
Contributor

@jalvz jalvz commented Apr 3, 2018

fixes #723

@roncohen
Copy link
Contributor

roncohen commented Apr 3, 2018

nice @jalvz. Seems like timestamp should be optional if we're not going to use it. WDYT? We could make the logic that if the timestamp is missing in the payload, APM Server will add it. And then we change the frontend agent to make sure it's not included in the payload. cc @jahtalab

@graphaelli
Copy link
Member

With all of the queueing we're doing I'm concerned that grabbing the timestamp at transform time will be late enough to be significant - what do you think?

Two options we could consider:

  • extend ProcessorFactory to accept a context object that we stick a time.Now value in
  • jam a ReceiveTime into config.Config

@jalvz
Copy link
Contributor Author

jalvz commented Apr 4, 2018

We could make the logic that if the timestamp is missing in the payload, APM Server will add it

sure. that is basically re-do this with an schema change, so closing this.

@jalvz jalvz closed this Apr 4, 2018
@jalvz jalvz deleted the override-rum-timestamp branch November 5, 2018 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Force a timestamp on RUM data
3 participants