package java-attacher alongside apm-server

[stuartnelson3]

Motivation/summary

download and package the java-attacher when executing make release

Checklist

• Update CHANGELOG.asciidoc
• Documentation has been updated

How to test these changes

run some different flavors of mage package, eg.

• DEV=true SNAPSHOT=true PLATFORMS=linux/amd64 TYPES=docker mage package
• DEV=true SNAPSHOT=true PLATFORMS=linux/amd64 TYPES=tar.gz mage package
• DEV=true SNAPSHOT=true PLATFORMS=linux/amd64 TYPES=deb mage package

and verify that java-attacher.jar is stored in the artifact alongside the apm-server binary

Related issues

#4824

[mergify]

This pull request does not have a backport label. Could you fix it @stuartnelson3? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-7.x is the label to automatically backport to the 7.x branch.
• backport-7./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

[apmmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2021-11-16T09:28:40.083+0000

• Duration: 52 min 25 sec

• Commit: c62bbec

Test stats 🧪

Test	Results
Failed	0
Passed	6022
Skipped	19
Total	6041

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

• /hey-apm : Run the hey-apm benchmark.

• /package : Generate and publish the docker images.

• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[stuartnelson3]

Note: in the tar.gz and docker container, the attacher is stored alongside the apm-server binary. this is also true in the .deb, where it's stored at ./usr/share/apm-server/bin/. I don't know if this is correct, though.

# dpkg --contents build/distributions/apm-server-8.1.0-SNAPSHOT-amd64.deb
drwxr-xr-x 0/0               0 2021-11-11 19:58 ./
drwxr-xr-x 0/0               0 2021-11-11 19:58 ./etc/
drwxr-xr-x 0/0               0 2021-11-11 19:58 ./etc/apm-server/
-rw-r--r-- 0/0          513253 2021-11-11 19:56 ./etc/apm-server/fields.yml
-rw------- 0/0           49030 2021-11-11 19:56 ./etc/apm-server/apm-server.yml
drwxr-xr-x 0/0               0 2021-11-11 19:58 ./etc/init.d/
-rwxr-xr-x 0/0            5073 2021-11-11 19:58 ./etc/init.d/apm-server
drwxr-xr-x 0/0               0 2021-11-11 19:58 ./lib/
drwxr-xr-x 0/0               0 2021-11-11 19:58 ./lib/systemd/
drwxr-xr-x 0/0               0 2021-11-11 19:58 ./lib/systemd/system/
-rw-r--r-- 0/0             640 2021-11-11 19:58 ./lib/systemd/system/apm-server.service
drwxr-xr-x 0/0               0 2021-11-11 19:58 ./usr/
drwxr-xr-x 0/0               0 2021-11-11 19:58 ./usr/share/
drwxr-xr-x 0/0               0 2021-11-11 19:58 ./usr/share/apm-server/
-rw-r--r-- 0/0         1215906 2021-11-11 09:45 ./usr/share/apm-server/NOTICE.txt
-rw-r--r-- 0/0              41 2021-11-11 19:58 ./usr/share/apm-server/.build_hash.txt
-rw-r--r-- 0/0             675 2021-11-11 19:58 ./usr/share/apm-server/README.md
drwxr-xr-x 0/0               0 2021-11-11 19:58 ./usr/share/apm-server/ingest/
drwxr-xr-x 0/0               0 2021-11-11 19:58 ./usr/share/apm-server/ingest/pipeline/
-rw-r--r-- 0/0            5589 2021-11-11 19:56 ./usr/share/apm-server/ingest/pipeline/definition.json
-rw-r--r-- 0/0            4234 2021-11-11 19:56 ./usr/share/apm-server/ingest/pipeline/definition.yml
drwxr-xr-x 0/0               0 2021-11-11 19:58 ./usr/share/apm-server/bin/
-rwxr-xr-x 0/0       128537776 2021-11-11 19:58 ./usr/share/apm-server/bin/apm-server
-rwxr-xr-x 0/0         1057147 2021-11-11 19:55 ./usr/share/apm-server/bin/apm-server-god
-rwxr-x--- 0/0        16511986 2021-11-11 19:56 ./usr/share/apm-server/bin/java-attacher.jar
-rw-r--r-- 0/0           13675 2021-05-28 15:23 ./usr/share/apm-server/LICENSE.txt
drwxr-xr-x 0/0               0 2021-11-11 19:58 ./usr/share/doc/
drwxr-xr-x 0/0               0 2021-11-11 19:58 ./usr/share/doc/apm-server/
-rw-r--r-- 0/0             138 2021-11-11 19:58 ./usr/share/doc/apm-server/changelog.gz
drwxr-xr-x 0/0               0 2021-11-11 19:58 ./usr/bin/
-rwxr-xr-x 0/0             339 2021-11-11 19:58 ./usr/bin/apm-server
drwxr-xr-x 0/0               0 2021-11-11 19:58 ./var/
drwxr-xr-x 0/0               0 2021-11-11 19:58 ./var/lib/
drwxr-xr-x 0/0               0 2021-11-11 19:55 ./var/lib/apm-server/
drwxr-xr-x 0/0               0 2021-11-11 19:58 ./var/log/
drwxr-xr-x 0/0               0 2021-11-11 19:55 ./var/log/apm-server/

[mergify]

This pull request is now in conflicts. Could you fix it @stuartnelson3? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b package-java-attacher upstream/package-java-attacher
git merge upstream/master
git push upstream package-java-attacher

[mergify]

This pull request is now in conflicts. Could you fix it @stuartnelson3? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b package-java-attacher upstream/package-java-attacher
git merge upstream/master
git push upstream package-java-attacher

[stuartnelson3]

@axw @felixbarny let me know if the gpg stuff aligns with what you want/expect, or if I should be storing the pubkey somewhere else.

[felixbarny]

LGTM

[axw]

looks great, thank you :)

[felixbarny]

Please wait until 1.27.0 is out before merging. Otherwise, just some minor suggestions.

[felixbarny]

I took the liberty to update the attacher version to the just released version 1.27.0

[stuartnelson3]

/test

[marclop]

Verified by downloading the apm-server from the latest 8.0 snapshot: https://snapshots.elastic.co/8.0.0-b0d1c470/summary-8.0.0-SNAPSHOT.html#apm-server