Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tail-Based sampling test automation script #6457

Closed
wants to merge 16 commits into from

Conversation

bryce-b
Copy link
Contributor

@bryce-b bryce-b commented Oct 28, 2021

Motivation/summary

This PR introduces a ./cmd/TBS/tbs-testing.py that allows automated testing of the tail-based sampling. The script accepts tail-based sampling configuration parameters, starts the apm-server with that config, generates transactions, and verifies the transactions are properly sampled.

Checklist

  • Update CHANGELOG.asciidoc
  • error handling around ES json inspection
  • Documentation has been update
  • add readme.md

How to test these changes

Related issues

#5484

@mergify
Copy link
Contributor

mergify bot commented Oct 28, 2021

This pull request does not have a backport label. Could you fix it @bryce-b? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.x is the label to automatically backport to the 7.x branch.
  • backport-7./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Oct 28, 2021
@apmmachine
Copy link
Contributor

apmmachine commented Oct 28, 2021

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-17T09:44:39.286+0000

  • Duration: 7 min 10 sec

Steps errors 1

Expand to view the steps failures

Run intake
  • Took 3 min 25 sec . View more details here
  • Description: ./.ci/scripts/intake.sh

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /hey-apm : Run the hey-apm benchmark.

  • /package : Generate and publish the docker images.

  • /test windows : Build & tests on Windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor

mergify bot commented Dec 7, 2021

This pull request is now in conflicts. Could you fix it @bryce-b? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b tbs-metrics upstream/tbs-metrics
git merge upstream/master
git push upstream tbs-metrics

@simitt
Copy link
Contributor

simitt commented Mar 21, 2022

Thank you for your testing efforts @bryce-b and for sharing your scripts for reproduction. TBS has been released as GA with 8.1. Any further performance tests will be conducted with a new WIP benchmarking approach; closing this PR.

@simitt simitt closed this Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants