Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warm phase from default ILM policy #6322

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Conversation

axw
Copy link
Member

@axw axw commented Oct 12, 2021

Motivation/summary

Remove warm phase from default ILM policy for standalone. Having a warm phase by default causes warm data nodes to spin up after 30 days when autoscaling is enabled; this is surprising to users, and was unintended.

This does not affect existing deployments unless they explicitly opt into overwriting the ILM policy during server initialisation/setup. Users who wish to have a warm phase and have enabled overwriting will need to customise their ILM policy in apm-server.yml.

Checklist

How to test these changes

  1. Run apm-server in a clean cluster
  2. Check that the the ILM policy created does not include a warm phase

Related issues

Closes #6170

@axw
Copy link
Member Author

axw commented Oct 12, 2021

@bmorelli25 FYI there are a few minor docs updates here.

@apmmachine
Copy link
Contributor

apmmachine commented Oct 12, 2021

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-12T05:51:21.933+0000

  • Duration: 51 min 49 sec

  • Commit: a763727

Test stats 🧪

Test Results
Failed 1
Passed 6184
Skipped 18
Total 6203

Test errors 1

Expand to view the tests failures

Build and Test / ARM build-test / TestModelIndexerLogRateLimit – modelindexer
    Expand to view the error details

     Failed 
    

    Expand to view the stacktrace

         indexer_test.go:256: 
        indexer_test.go:257:  
    

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /hey-apm : Run the hey-apm benchmark.

  • /package : Generate and publish the docker images.

@axw axw marked this pull request as ready for review October 12, 2021 06:37
@axw axw requested a review from a team October 12, 2021 06:37
@axw axw merged commit c3d27d4 into elastic:master Oct 12, 2021
@axw axw deleted the ilm-no-warm branch October 12, 2021 06:48
mergify bot pushed a commit that referenced this pull request Oct 12, 2021
(cherry picked from commit c3d27d4)

# Conflicts:
#	changelogs/head.asciidoc
axw added a commit that referenced this pull request Oct 12, 2021
* Remove warm phase from default ILM policy (#6322)

(cherry picked from commit c3d27d4)

# Conflicts:
#	changelogs/head.asciidoc

* Delete head.asciidoc

Co-authored-by: Andrew Wilkins <[email protected]>
@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2021

This pull request does not have a backport label. Could you fix it @axw? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.x is the label to automatically backport to the 7.x branch.
  • backport-7./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Oct 25, 2021
@marclop marclop self-assigned this Oct 28, 2021
@marclop
Copy link
Contributor

marclop commented Oct 28, 2021

Verified using 7.16.0 BC1:

GET _ilm/policy/apm-rollover-30-days
{
  "policy": {
    "phases": {
      "hot": {
        "min_age": "0ms",
        "actions": {
          "rollover": {
            "max_size": "50gb",
            "max_age": "30d"
          },
          "set_priority": {
            "priority": 100
          }
        }
      }
    }
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify test-plan test-plan-ok v7.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default ILM template for APM uses hot/warm
3 participants