Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beater: watch output config changes #6289

Merged
merged 4 commits into from
Oct 5, 2021

Conversation

axw
Copy link
Member

@axw axw commented Oct 5, 2021

Motivation/summary

Watch libbeat output config changes, and restart the beater with updated config. This enables us to propagate the Elasticsearch output config to tail-based sampling when running under Fleet.

Checklist

- [ ] Update CHANGELOG.asciidoc (non user facing change)
- [ ] Documentation has been updated

How to test these changes

Can't be manually tested yet, needs UI for configuring tail-sampling policies.

Related issues

#5490

@axw axw marked this pull request as ready for review October 5, 2021 03:49
@axw axw requested a review from a team October 5, 2021 03:49
@apmmachine
Copy link
Contributor

apmmachine commented Oct 5, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-05T10:06:46.727+0000

  • Duration: 46 min 6 sec

  • Commit: 99d4b02

Test stats 🧪

Test Results
Failed 0
Passed 6145
Skipped 14
Total 6159

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /hey-apm : Run the hey-apm benchmark.

  • /package : Generate and publish the docker images.

Copy link
Contributor

@simitt simitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks for adding the comments.

@axw axw merged commit c24054a into elastic:master Oct 5, 2021
@axw axw deleted the beater-output-config-reloader branch October 5, 2021 12:22
mergify bot pushed a commit that referenced this pull request Oct 5, 2021
axw added a commit that referenced this pull request Oct 6, 2021
(cherry picked from commit c24054a)

Co-authored-by: Andrew Wilkins <[email protected]>
@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2021

This pull request does not have a backport label. Could you fix it @axw? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.x is the label to automatically backport to the 7.x branch.
  • backport-7./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Oct 25, 2021
@marclop marclop assigned marclop and unassigned marclop Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify test-plan test-plan-skip v7.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants