-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
publish: implement BatchProcessor; remove tracing #6243
Conversation
673d7a0
to
f9e0feb
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
Modify publish.Publisher so that it implements model.BatchProcessor directly. Remove the tracing instrumentation from publisher. We no longer use and don't support libbeat processors, so this is not useful.
f9e0feb
to
5cc94a9
Compare
This pull request is now in conflicts. Could you fix it @axw? 🙏
|
Modify publish.Publisher so that it implements model.BatchProcessor directly. Remove the tracing instrumentation from publisher. We no longer use and don't support libbeat processors, so this is not useful. (cherry picked from commit 79b43c1) # Conflicts: # changelogs/head.asciidoc
…) (#6279) * publish: implement BatchProcessor; remove tracing (#6243) Modify publish.Publisher so that it implements model.BatchProcessor directly. Remove the tracing instrumentation from publisher. We no longer use and don't support libbeat processors, so this is not useful. (cherry picked from commit 79b43c1) # Conflicts: # changelogs/head.asciidoc * Delete head.asciidoc Co-authored-by: Andrew Wilkins <[email protected]>
This pull request does not have a backport label. Could you fix it @axw? 🙏
NOTE: |
Tested with
GET apm-*,traces-apm*,logs-apm*/_search
{
"query": {
"bool": {
"should": [
{
"match": {
"transaction.type": "Publisher"
}
},
{
"match": {
"span.type": "Publisher"
}
}
]
}
}
} |
Motivation/summary
publish.Publisher
so that it implementsmodel.BatchProcessor
directly.Checklist
- [ ] Documentation has been updatedHow to test these changes
Related issues
Related to #6002