Introduce dedicated fields for internal metrics #6111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
force-pushed
the
known-metric-fields
branch
from
a39bd58 to
56bf32c
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
Add dedicated fields to model.Transaction and model.Span for well-defined, internal transaction and span metrics. Drop unknown metrics received in metricsets with any transaction or span fields defined. Internal metrics will be indexed with strict mapping. We already have explicitly defined fields for these metrics. This PR ensures that unknown metrics do not slip through. If an agent is upgraded before the server and some new internal metric starts being produced, that must not be indexed as it would cause other internal metrics to be rejected by Elasticsearch. Drop the unused `metricset.period` field that was being added to service_destination metrics.
axw
force-pushed
the
known-metric-fields
branch
from
56bf32c to
6003197
Compare
simitt
approved these changes
Sep 3, 2021
mergify bot
pushed a commit
that referenced
this pull request
Sep 3, 2021
* Introduce dedicated fields for internal metrics Add dedicated fields to model.Transaction and model.Span for well-defined, internal transaction and span metrics. Drop unknown metrics received in metricsets with any transaction or span fields defined. Internal metrics will be indexed with strict mapping. We already have explicitly defined fields for these metrics. This PR ensures that unknown metrics do not slip through. If an agent is upgraded before the server and some new internal metric starts being produced, that must not be indexed as it would cause other internal metrics to be rejected by Elasticsearch. Drop the unused `metricset.period` field that was being added to service_destination metrics. * Fix systemtest approvals (cherry picked from commit d37d372) # Conflicts: # changelogs/head.asciidoc
axw
added a commit
that referenced
this pull request
Sep 3, 2021
#6118) * Introduce dedicated fields for internal metrics (#6111) * Introduce dedicated fields for internal metrics Add dedicated fields to model.Transaction and model.Span for well-defined, internal transaction and span metrics. Drop unknown metrics received in metricsets with any transaction or span fields defined. Internal metrics will be indexed with strict mapping. We already have explicitly defined fields for these metrics. This PR ensures that unknown metrics do not slip through. If an agent is upgraded before the server and some new internal metric starts being produced, that must not be indexed as it would cause other internal metrics to be rejected by Elasticsearch. Drop the unused `metricset.period` field that was being added to service_destination metrics. * Fix systemtest approvals (cherry picked from commit d37d372) # Conflicts: # changelogs/head.asciidoc * Delete head.asciidoc Co-authored-by: Andrew Wilkins <[email protected]>
1 task
marclop
added
backport-skip
|
Tested with
|
|
This PR said the field metricset.period is removed but why the document still mentioned the field here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Add dedicated fields to model.Transaction and model.Span for well-defined, internal transaction and span metrics. Drop unknown metrics received in metricsets with any transaction or span fields defined.
Internal metrics will be indexed with strict mapping. We already have explicitly defined fields for these metrics. This PR ensures that unknown metrics do not slip through. If an agent is upgraded before the server and some new internal metric starts being produced, that must not be indexed as it would cause other internal metrics to be rejected by Elasticsearch.
Drop the unused
metricset.periodfield that was being added to service_destination metrics.Checklist
- [ ] Documentation has been updatedHow to test these changes
-E instrumentation.enabled=trueRelated issues