beater: create listener synchronously in Reload #6054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
added
v7.15.0
backport-7.x
backport-7.15
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
axw
force-pushed
the
beater-listen-sync
branch
from
c3622fa to
bd2ec9c
Compare
mergify bot
pushed a commit
that referenced
this pull request
Aug 26, 2021
(cherry picked from commit 5453de4)
mergify bot
pushed a commit
that referenced
this pull request
Aug 26, 2021
(cherry picked from commit 5453de4)
axw
added a commit
that referenced
this pull request
Aug 26, 2021
(cherry picked from commit 5453de4) Co-authored-by: Andrew Wilkins <[email protected]>
axw
added a commit
that referenced
this pull request
Aug 27, 2021
(cherry picked from commit 5453de4) Co-authored-by: Andrew Wilkins <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Create socket listener synchronously in the beater Reload method, to ensure there is a new active listener before the existing listener is closed.
Checklist
- [ ] Update CHANGELOG.asciidoc- [ ] Documentation has been updatedHow to test these changes
See #6050
Related issues
Fixes #6050